From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
idosch@mellanox.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 1/5] net: fib_rules: support for match on ip_proto, sport and dport
Date: Thu, 01 Mar 2018 14:48:48 -0800 [thread overview]
Message-ID: <1519944528.11375.5.camel@gmail.com> (raw)
In-Reply-To: <1519789965-3465-2-git-send-email-roopa@cumulusnetworks.com>
On Tue, 2018-02-27 at 19:52 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> uapi for ip_proto, sport and dport range match
> in fib rules.
Hi Roopa
FRA_UNSPEC,
> FRA_DST, /* destination address */
> @@ -59,6 +64,9 @@ enum {
> FRA_L3MDEV, /* iif or oif is l3mdev goto its table */
> FRA_UID_RANGE, /* UID range */
> FRA_PROTOCOL, /* Originator of the rule */
> + FRA_IP_PROTO, /* ip proto */
> + FRA_SPORT_RANGE, /* sport */
> + FRA_DPORT_RANGE, /* dport */
> __FRA_MAX
> };
It seems you forgot to update FRA_GENERIC_POLICY ?
Thanks !
next prev parent reply other threads:[~2018-03-01 22:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:52 [PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match Roopa Prabhu
2018-02-28 3:52 ` [PATCH net-next v2 1/5] net: fib_rules: support for match on ip_proto, sport and dport Roopa Prabhu
2018-02-28 13:08 ` Nikolay Aleksandrov
2018-03-01 22:48 ` Eric Dumazet [this message]
2018-03-01 23:08 ` Roopa Prabhu
2018-02-28 3:52 ` [PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto Roopa Prabhu
2018-02-28 13:09 ` Nikolay Aleksandrov
2018-02-28 3:52 ` [PATCH net-next v2 3/5] ipv6: fib6_rules: support for " Roopa Prabhu
2018-02-28 13:10 ` Nikolay Aleksandrov
2018-02-28 3:52 ` [PATCH net-next v2 4/5] ipv4: route: dissect flow in input path if fib rules need it Roopa Prabhu
2018-02-28 9:59 ` Paolo Abeni
2018-02-28 13:13 ` Nikolay Aleksandrov
2018-02-28 3:52 ` [PATCH net-next v2 5/5] ipv6: " Roopa Prabhu
2018-02-28 10:05 ` Paolo Abeni
2018-02-28 13:20 ` Nikolay Aleksandrov
2018-02-28 16:59 ` [PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match David Miller
2018-02-28 18:11 ` David Ahern
2018-02-28 19:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519944528.11375.5.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pabeni@redhat.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).