From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f66.google.com ([74.125.83.66]:39318 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1162589AbeCAWsv (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Mar 2018 17:48:51 -0500
Received: by mail-pg0-f66.google.com with SMTP id w16so2045144pgv.6
        for <netdev@vger.kernel.org>; Thu, 01 Mar 2018 14:48:50 -0800 (PST)
Message-ID: <1519944528.11375.5.camel@gmail.com>
Subject: Re: [PATCH net-next v2 1/5] net: fib_rules: support for match on
 ip_proto, sport and dport
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>, davem@davemloft.net,
        netdev@vger.kernel.org
Cc: dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
        idosch@mellanox.com, pabeni@redhat.com
Date: Thu, 01 Mar 2018 14:48:48 -0800
In-Reply-To: <1519789965-3465-2-git-send-email-roopa@cumulusnetworks.com>
References: <1519789965-3465-1-git-send-email-roopa@cumulusnetworks.com>
         <1519789965-3465-2-git-send-email-roopa@cumulusnetworks.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 2018-02-27 at 19:52 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> uapi for ip_proto, sport and dport range match
> in fib rules.


Hi Roopa

 	FRA_UNSPEC,
>  	FRA_DST,	/* destination address */
> @@ -59,6 +64,9 @@ enum {
>  	FRA_L3MDEV,	/* iif or oif is l3mdev goto its table */
>  	FRA_UID_RANGE,	/* UID range */
>  	FRA_PROTOCOL,   /* Originator of the rule */
> +	FRA_IP_PROTO,	/* ip proto */
> +	FRA_SPORT_RANGE, /* sport */
> +	FRA_DPORT_RANGE, /* dport */
>  	__FRA_MAX
>  };


It seems you forgot to update FRA_GENERIC_POLICY ?

Thanks !