From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs
Date: Thu, 01 Mar 2018 18:18:06 -0800 [thread overview]
Message-ID: <1519957086.11375.6.camel@gmail.com> (raw)
In-Reply-To: <1519955737-46689-1-git-send-email-roopa@cumulusnetworks.com>
On Thu, 2018-03-01 at 17:55 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> include/net/fib_rules.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
> index 6dd0a00..1c9e17c 100644
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -112,7 +112,11 @@ struct fib_rule_notifier_info {
> [FRA_GOTO] = { .type = NLA_U32 }, \
> [FRA_L3MDEV] = { .type = NLA_U8 }, \
> [FRA_UID_RANGE] = { .len = sizeof(struct fib_rule_uid_range) }, \
> - [FRA_PROTOCOL] = { .type = NLA_U8 }
> + [FRA_PROTOCOL] = { .type = NLA_U8 }, \
> + [FRA_IP_PROTO] = { .type = NLA_U8 }, \
> + [FRA_SPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }, \
> + [FRA_DPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }
> +
Thanks Roopa !
Reviewed-by: Eric Dumazet <edumazet@google.com>
prev parent reply other threads:[~2018-03-02 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 1:55 [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs Roopa Prabhu
2018-03-02 2:14 ` David Miller
2018-03-02 2:18 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519957086.11375.6.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).