From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:46456 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163939AbeCBCSI (ORCPT ); Thu, 1 Mar 2018 21:18:08 -0500 Received: by mail-pg0-f65.google.com with SMTP id r26so3140631pgv.13 for ; Thu, 01 Mar 2018 18:18:08 -0800 (PST) Message-ID: <1519957086.11375.6.camel@gmail.com> Subject: Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs From: Eric Dumazet To: Roopa Prabhu , davem@davemloft.net, netdev@vger.kernel.org Date: Thu, 01 Mar 2018 18:18:06 -0800 In-Reply-To: <1519955737-46689-1-git-send-email-roopa@cumulusnetworks.com> References: <1519955737-46689-1-git-send-email-roopa@cumulusnetworks.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2018-03-01 at 17:55 -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport") > Reported-by: Eric Dumazet > Signed-off-by: Roopa Prabhu > --- > include/net/fib_rules.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h > index 6dd0a00..1c9e17c 100644 > --- a/include/net/fib_rules.h > +++ b/include/net/fib_rules.h > @@ -112,7 +112,11 @@ struct fib_rule_notifier_info { > [FRA_GOTO] = { .type = NLA_U32 }, \ > [FRA_L3MDEV] = { .type = NLA_U8 }, \ > [FRA_UID_RANGE] = { .len = sizeof(struct fib_rule_uid_range) }, \ > - [FRA_PROTOCOL] = { .type = NLA_U8 } > + [FRA_PROTOCOL] = { .type = NLA_U8 }, \ > + [FRA_IP_PROTO] = { .type = NLA_U8 }, \ > + [FRA_SPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }, \ > + [FRA_DPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) } > + Thanks Roopa ! Reviewed-by: Eric Dumazet