From: Eric Dumazet <eric.dumazet@gmail.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, jishi@redhat.com, sbrivio@redhat.com
Subject: Re: [PATCH net-next] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()
Date: Fri, 02 Mar 2018 12:23:17 -0800 [thread overview]
Message-ID: <1520022197.13201.1.camel@gmail.com> (raw)
In-Reply-To: <5a4746774cf7dc8d44598c4595721fba679c481a.1519987422.git.lorenzo.bianconi@redhat.com>
On Fri, 2018-03-02 at 11:53 +0100, Lorenzo Bianconi wrote:
> Fix the following slab-out-of-bounds kasan report in
> ndisc_fill_redirect_hdr_option when the incoming ipv6 packet is not
> linear and the accessed data are not in the linear data region of orig_skb
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
> net/ipv6/ndisc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index 0a19ce3a6f7f..afd8c15827cd 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -1554,7 +1554,8 @@ static void ndisc_fill_redirect_hdr_option(struct sk_buff *skb,
> *(opt++) = (rd_len >> 3);
> opt += 6;
>
> - memcpy(opt, ipv6_hdr(orig_skb), rd_len - 8);
> + skb_copy_bits(orig_skb, skb_network_offset(orig_skb), opt,
> + rd_len - 8);
> }
Wow, nice catch !
Reviewed-by: Eric Dumazet <edumazet@google.com>
prev parent reply other threads:[~2018-03-02 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1519987422.git.lorenzo.bianconi@redhat.com>
2018-03-02 10:53 ` [PATCH net-next] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option() Lorenzo Bianconi
2018-03-02 14:59 ` David Miller
2018-03-05 15:56 ` Lorenzo Bianconi
2018-03-02 20:23 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520022197.13201.1.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jishi@redhat.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).