From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: netdev@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] sch_netem: fix skb leak in netem_enqueue()
Date: Fri, 02 Mar 2018 19:30:27 -0800 [thread overview]
Message-ID: <1520047827.13201.3.camel@gmail.com> (raw)
In-Reply-To: <20180302104423.645c41d0@xeon-e3>
On Fri, 2018-03-02 at 10:44 -0800, Stephen Hemminger wrote:
> On Fri, 2 Mar 2018 21:16:48 +0300
>
> Since this is a generic problem why is not fixed in qdisc_drop instead?
AFAIK only netem and tbf might segment GSO packets so far.
I am not sure we want to add code in qdisc_drop() that is used under
stress on normal qdiscs and are inline code.
next prev parent reply other threads:[~2018-03-03 3:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 18:16 [PATCH net] sch_netem: fix skb leak in netem_enqueue() Alexey Kodanev
2018-03-02 18:44 ` Stephen Hemminger
2018-03-03 3:30 ` Eric Dumazet [this message]
2018-03-03 12:20 ` Neil Horman
2018-03-05 12:57 ` Alexey Kodanev
2018-03-05 15:13 ` Eric Dumazet
2018-03-05 15:40 ` Alexey Kodanev
2018-03-05 23:11 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520047827.13201.3.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).