From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f43.google.com ([74.125.83.43]:45289 "EHLO
        mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750810AbeCCDa3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Mar 2018 22:30:29 -0500
Received: by mail-pg0-f43.google.com with SMTP id i133so4539535pgc.12
        for <netdev@vger.kernel.org>; Fri, 02 Mar 2018 19:30:29 -0800 (PST)
Message-ID: <1520047827.13201.3.camel@gmail.com>
Subject: Re: [PATCH net] sch_netem: fix skb leak in netem_enqueue()
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
        Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: netdev@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
        David Miller <davem@davemloft.net>
Date: Fri, 02 Mar 2018 19:30:27 -0800
In-Reply-To: <20180302104423.645c41d0@xeon-e3>
References: <1520014608-512-1-git-send-email-alexey.kodanev@oracle.com>
         <20180302104423.645c41d0@xeon-e3>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 2018-03-02 at 10:44 -0800, Stephen Hemminger wrote:
> On Fri,  2 Mar 2018 21:16:48 +0300
> 
> Since this is a generic problem why is not fixed in qdisc_drop instead?

AFAIK only netem and tbf might segment GSO packets so far.

I am not sure we want to add code in qdisc_drop() that is used under
stress on normal qdiscs and are inline code.