From: Paul Blakey <paulb@mellanox.com>
To: Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Yevgeny Kliteynik <kliteyn@mellanox.com>,
Roi Dayan <roid@mellanox.com>,
Shahar Klein <shahark@mellanox.com>,
Mark Bloch <markb@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
Paul Blakey <paulb@mellanox.com>
Subject: [PATCH net 0/2] rhashtable: Fix rhltable duplicates insertion
Date: Sun, 4 Mar 2018 14:34:25 +0200 [thread overview]
Message-ID: <1520166867-4215-1-git-send-email-paulb@mellanox.com> (raw)
On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenrio happened,
insertion of a flow group with a similar match criteria (duplicate),
but only where the flow group rhash_head was second (or not first)
on the relevant rhashtable bucket list.
The first patch fixes it, and the second one adds a test that show
it is now working.
Paul Blakey (2):
rhashtable: Fix rhltable duplicates insertion
test_rhashtable: add test case for rhl_table with duplicate objects
include/linux/rhashtable.h | 4 +-
lib/test_rhashtable.c | 121 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 124 insertions(+), 1 deletion(-)
--
1.8.4.3
next reply other threads:[~2018-03-04 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:34 Paul Blakey [this message]
2018-03-04 12:34 ` [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion Paul Blakey
2018-03-04 12:57 ` Herbert Xu
2018-03-04 13:27 ` Paul Blakey
2018-03-04 14:16 ` Herbert Xu
2018-03-04 12:34 ` [PATCH net 2/2] test_rhashtable: add test case for rhl_table with duplicate objects Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520166867-4215-1-git-send-email-paulb@mellanox.com \
--to=paulb@mellanox.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=markb@mellanox.com \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roid@mellanox.com \
--cc=shahark@mellanox.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).