From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:37724 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752682AbeCDMek (ORCPT ); Sun, 4 Mar 2018 07:34:40 -0500 From: Paul Blakey To: Thomas Graf , Herbert Xu , David Miller Cc: netdev@vger.kernel.org, Yevgeny Kliteynik , Roi Dayan , Shahar Klein , Mark Bloch , Jiri Pirko , Or Gerlitz , Matan Barak , Paul Blakey Subject: [PATCH net 0/2] rhashtable: Fix rhltable duplicates insertion Date: Sun, 4 Mar 2018 14:34:25 +0200 Message-Id: <1520166867-4215-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On our mlx5 driver fs_core.c, we use the rhltable interface to store flow groups. We noticed that sometimes we get a warning that flow group isn't found at removal. This rare case was caused when a specific scenrio happened, insertion of a flow group with a similar match criteria (duplicate), but only where the flow group rhash_head was second (or not first) on the relevant rhashtable bucket list. The first patch fixes it, and the second one adds a test that show it is now working. Paul Blakey (2): rhashtable: Fix rhltable duplicates insertion test_rhashtable: add test case for rhl_table with duplicate objects include/linux/rhashtable.h | 4 +- lib/test_rhashtable.c | 121 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 124 insertions(+), 1 deletion(-) -- 1.8.4.3