From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f176.google.com ([209.85.192.176]:39197 "EHLO
        mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751835AbeCEPNl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 5 Mar 2018 10:13:41 -0500
Received: by mail-pf0-f176.google.com with SMTP id u5so7308081pfh.6
        for <netdev@vger.kernel.org>; Mon, 05 Mar 2018 07:13:41 -0800 (PST)
Message-ID: <1520262818.109662.1.camel@gmail.com>
Subject: Re: [PATCH net] sch_netem: fix skb leak in netem_enqueue()
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>,
        Neil Horman <nhorman@tuxdriver.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Date: Mon, 05 Mar 2018 07:13:38 -0800
In-Reply-To: <4a06d0d1-6518-c7d0-f947-f427cf3688d4@oracle.com>
References: <1520014608-512-1-git-send-email-alexey.kodanev@oracle.com>
         <20180303122047.GA8802@hmswarspite.think-freely.org>
         <4a06d0d1-6518-c7d0-f947-f427cf3688d4@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 2018-03-05 at 15:57 +0300, Alexey Kodanev wrote:
> 
> +static inline void __qdisc_drop_all(struct sk_buff *skb,
> +                                   struct sk_buff **to_free)
> +{
> +       struct sk_buff *first = skb;
> +
> +       while (skb->next)
> +               skb = skb->next;
> +
> +       skb->next = *to_free;
> +       *to_free = first;
> +}

You probably can leverage what I did for commit bec3cfdca36bf43cfa
("net: skb_segment() provides list head and tail")
to avoid the iteration.