From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mga05.intel.com ([192.55.52.43]:41779 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753006AbeCETJG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 5 Mar 2018 14:09:06 -0500
Message-ID: <1520276969.5010.2.camel@intel.com>
Subject: Re: [net-next 4/4] e1000e: allocate ring descriptors with
 dma_zalloc_coherent
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Reply-To: jeffrey.t.kirsher@intel.com
To: Eric Dumazet <eric.dumazet@gmail.com>, davem@davemloft.net
Cc: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>, netdev@vger.kernel.org,
        nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com,
        Marius Gligor <mgligor@kalray.eu>
Date: Mon, 05 Mar 2018 11:09:29 -0800
In-Reply-To: <1520274223.109662.8.camel@gmail.com>
References: <20180305181631.3872-1-jeffrey.t.kirsher@intel.com>
         <20180305181631.3872-5-jeffrey.t.kirsher@intel.com>
         <1520274223.109662.8.camel@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-qCeEXMRdb7nV0qjEyDcg"
Mime-Version: 1.0
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-qCeEXMRdb7nV0qjEyDcg
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote:
> On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote:
> > From: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>
> >=20
> > Descriptor rings were not initialized at zero when allocated
> > When area contained garbage data, it caused skb_over_panic in
> > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set)
> >=20
> > This patch makes use of dma_zalloc_coherent to make sure the
> > ring is memset at 0 to prevent the area from containing garbage.
> >=20
>=20
> This looks like a net candidate, fixing a bug, with 0 chance adding a
> regression IMO.

I am fine with that.  Dave, let me know if you want me to re-submit
this change for net/stable.
--=-qCeEXMRdb7nV0qjEyDcg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlqdlekACgkQ5W/vlVpL
7c5NWg/8C2M5AlJzgvcNSfl7PNTjR6GFHXgAHw0VgTNkrJ2cxdu0avkUiMYUTxgU
EMci3PEXrZyZ3FIdtnXc/jAhwEubtsRj0WuhxvYxhP5N21cRJxt/qAd5vYsFhZjm
KBGB5C28yaW3+zS8uEOWBClUJ9e5Mp5bJco6CAJk1Cx1ILvdlaJcQr0vrB0pRmxF
MuxFrAZ4U7OP65KysSCYGXzq2MVPcPOnAJ2lcEgCMybegvkr0+NnfQGcnTYtkUp/
kUJhnTGcb1HAt3IZVFA/AnefZQ8ZB0JDZxm/VGqZHOlD7nYwdGud7uMJs1GLEM9e
G6HtEPRmDiwG85zoAONOUoIxa1cuoUmOCOxvWxEdpEwGtic6M7DtCdk1vf23bCVP
QQ/7BDPZbvDzUYjJHb2l6Cc6usSKcQWW8CirWCQUoXf3hOyD3ZhkbrfzY+uKL0th
xjZEaVClTi1VSxRGcDVisKCLAsSS/keT81CiIpmDVj9GjbdcT9IS31AeBMTU2zSE
lMywEaSCdUzXQcO8bVwVWHR8p5ItX0k9AEV6Fg1/y3EX8v0DlKIEF+f8i3SjE9zV
8a78BTUgVTfpY05Jm3y9A+CrO7IJvRPM9k+2XktJ7CQ/5Xaq9zVCHLz2THgzGk5Y
Hni8pKX5LXClUenVNCj10oP0Kr23B3QZzTee+iF5e79JMiTObO8=
=IsF0
-----END PGP SIGNATURE-----

--=-qCeEXMRdb7nV0qjEyDcg--