From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:23703 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932505AbeCEVlx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 5 Mar 2018 16:41:53 -0500
Message-ID: <1520286124.5010.3.camel@intel.com>
Subject: Re: [net-next 4/4] e1000e: allocate ring descriptors with
 dma_zalloc_coherent
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Reply-To: jeffrey.t.kirsher@intel.com
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, pkerbrat@kalray.eu, netdev@vger.kernel.org,
        nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com,
        mgligor@kalray.eu
Date: Mon, 05 Mar 2018 13:42:04 -0800
In-Reply-To: <20180305.162040.1738604452489890352.davem@davemloft.net>
References: <20180305181631.3872-5-jeffrey.t.kirsher@intel.com>
         <1520274223.109662.8.camel@gmail.com> <1520276969.5010.2.camel@intel.com>
         <20180305.162040.1738604452489890352.davem@davemloft.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-mX4p9261h+OsMOPJQdnY"
Mime-Version: 1.0
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-mX4p9261h+OsMOPJQdnY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2018-03-05 at 16:20 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Mon, 05 Mar 2018 11:09:29 -0800
>=20
> > On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote:
> > > On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote:
> > > > From: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>
> > > >=20
> > > > Descriptor rings were not initialized at zero when allocated
> > > > When area contained garbage data, it caused skb_over_panic in
> > > > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set)
> > > >=20
> > > > This patch makes use of dma_zalloc_coherent to make sure the
> > > > ring is memset at 0 to prevent the area from containing
> > > > garbage.
> > > >=20
> > >=20
> > > This looks like a net candidate, fixing a bug, with 0 chance
> > > adding a
> > > regression IMO.
> >=20
> > I am fine with that.  Dave, let me know if you want me to re-submit
> > this change for net/stable.
>=20
> Yes, please add this patch to the net-queue pull request you also
> sent today.
>=20
> Thanks.

Done.
--=-mX4p9261h+OsMOPJQdnY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlqduawACgkQ5W/vlVpL
7c4JOw/+JhdaLmxbjsX2n/+Z+U3DF4wYY6KvQLx7ndrijmTBOna7PIlOHa4NQd87
PoXAHutQQo/qjFpM0KfVw2e86EuMtJUWMmNmjv/IJMircrbfwNgMhWsmaT1SUwlC
U8Csxoi9/glt1fUU/nP3aoHhG4JzFM6IPntv/uJolyVYgtTR6kicdENY3gux4YPU
Qpasen6wb7SQDKdFsQ9WfbAPOBhPHbikvr1eVv/vGn/pGgVAqp2yKjEamKcQ/1Zd
T/gKrKNDWqvE3zk7IVVOuuCZi80ac9ILmjZnMV3frzRXt96jRZJfLR8YzTFWknZz
tZNB/ZC3MCtGbDs4ThSALJLtf9pUqL8O8xsSC11Q/dZTiOr1Pl/TzxzbUj4TJlzZ
9CtxI2CnY0hPXvxQknrf1a7NbHcdOzw98O5V7Uv3sLt2t2+ZaMRiwQiqvDlGf6tB
sBHgcNeLlbXdg0sHZNailE2a/+/o7s/pGpEEpqrdQ02OMVK6oYX/e3/D1G1xK/1q
KC3JhPUZcU+Y0HilVyhZYPsOvpleYqFQuJzuG0RBgjl0NVo8UpgCJV2oFn5w9pEk
N89Cpv0N2lfdmttKxLvt8eZlFR510ry4w3Wr5YR+9YjwU6wRr3nuB1N/odHdGnTL
gtdBJmZ0TQ4VAhIj5hCVjXVM5r32ygDFs2b3MK9rSQcKWrtIX4U=
=NNmR
-----END PGP SIGNATURE-----

--=-mX4p9261h+OsMOPJQdnY--