From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:46104 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbeCFRUd (ORCPT ); Tue, 6 Mar 2018 12:20:33 -0500 Received: by mail-pl0-f67.google.com with SMTP id y8-v6so12205033pll.13 for ; Tue, 06 Mar 2018 09:20:33 -0800 (PST) Message-ID: <1520356831.109662.25.camel@gmail.com> Subject: Re: [PATCH RESEND net-next] net: Do synchronize_rcu() in ip6mr_sk_done() only if this is needed From: Eric Dumazet To: Kirill Tkhai , davem@davemloft.net, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org Cc: Yuval Mintz Date: Tue, 06 Mar 2018 09:20:31 -0800 In-Reply-To: <1520355533.109662.24.camel@gmail.com> References: <152035343583.28894.2225634076957704200.stgit@localhost.localdomain> <1520355021.109662.22.camel@gmail.com> <1520355533.109662.24.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2018-03-06 at 08:58 -0800, Eric Dumazet wrote: > > To be clear, your patch is fine Kirill, > > I am only sad seeing one can add a synchronize_rcu() in hot path > without anyone complaining during code review. lpaa2:~# time for i in {1..1000}; do unshare -n /bin/false;done real 7m18.911s user 0m0.185s sys 0m2.314s Instead of less than 10 seconds not a long time ago :/