From: Roman Mashak <mrv@mojatatu.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
Roman Mashak <mrv@mojatatu.com>
Subject: [PATCH v2 net-next 0/4] Fix event generation for actions batch Add/Delete mode
Date: Tue, 6 Mar 2018 16:55:20 -0500 [thread overview]
Message-ID: <1520373324-17433-1-git-send-email-mrv@mojatatu.com> (raw)
When adding or deleting a batch of entries, the kernel sends upto
TCA_ACT_MAX_PRIO entries in an event to user space. However it does not
consider that the action sizes may vary and require different skb sizes.
For example :
% cat tc-batch.sh
#!/bin/bash
TC="sudo /mnt/iproute2.git/tc/tc"
$TC actions flush action gact
for i in `seq 1 $1`;
do
cmd="action pass index $i "
args=$args$cmd
done
$TC actions add $args
%
% ./tc-batch.sh 32
Error: Failed to fill netlink attributes while adding TC action.
We have an error talking to the kernel
%
This patchset introduces new callback in tc_action_ops, which calculates
the action size, and passes size to tcf_add_notify()/tcf_del_notify(). The
patch fixes act_gact, and the rest of actions will be updated in the
follow-up patches.
v2:
Restructured patches to make them bisectable.
Roman Mashak (4):
net sched actions: update Add/Delete action API with new argument
net sched actions: add new tc_action_ops callback
net sched actions: calculate add/delete event message size
net sched actions: implement get_fill_size routine in act_gact
include/net/act_api.h | 4 +++-
net/sched/act_api.c | 63 ++++++++++++++++++++++++++++++++++++++++++++-------
net/sched/act_gact.c | 14 ++++++++++++
net/sched/cls_api.c | 3 ++-
4 files changed, 74 insertions(+), 10 deletions(-)
--
2.7.4
next reply other threads:[~2018-03-06 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 21:55 Roman Mashak [this message]
2018-03-06 21:55 ` [PATCH v2 net-next 1/4] net sched actions: update Add/Delete action API with new argument Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 2/4] net sched actions: add new tc_action_ops callback Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size Roman Mashak
2018-03-07 19:55 ` David Miller
2018-03-07 20:43 ` Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 4/4] net sched actions: implement get_fill_size routine in act_gact Roman Mashak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520373324-17433-1-git-send-email-mrv@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).