From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>,
netdev@vger.kernel.org
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
vinicius.gomes@intel.com, richardcochran@gmail.com,
intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de,
henrik@austad.us, tglx@linutronix.de, john.stultz@linaro.org,
levi.pearson@harman.com, edumazet@google.com, willemb@google.com,
mlichvar@redhat.com
Subject: Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params
Date: Tue, 06 Mar 2018 18:53:29 -0800 [thread overview]
Message-ID: <1520391209.109662.33.camel@gmail.com> (raw)
In-Reply-To: <20180307011230.24001-9-jesus.sanchez-palencia@intel.com>
On Tue, 2018-03-06 at 17:12 -0800, Jesus Sanchez-Palencia wrote:
> Extend SO_TXTIME APIs with new per-packet parameters: a clockid_t and
> a drop_if_late flag. With this commit the API becomes:
>
>
* diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
* index d8340e6e8814..951969ceaf65 100644
* --- a/include/linux/skbuff.h
* +++ b/include/linux/skbuff.h
* @@ -788,6 +788,9 @@ struct sk_buff {
* __u8 tc_redirected:1;
* __u8 tc_from_ingress:1;
* #endif
* + __u8 tc_drop_if_late:1;
* +
* + clockid_t txtime_clockid;
*
* #ifdef CONFIG_NET_SCHED
* __u16 tc_index; /* traffic
control index */
This is adding 32+1 bits to sk_buff, and possibly holes in this very
very hot (and already too fat) structure.
Do we really need 32 bits for a clockid_t ?
next prev parent reply other threads:[~2018-03-07 2:53 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 1:12 [RFC v3 net-next 00/18] Time based packet transmission Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 01/18] sock: Fix SO_ZEROCOPY switch case Jesus Sanchez-Palencia
2018-03-07 16:58 ` Willem de Bruijn
2018-03-07 1:12 ` [RFC v3 net-next 02/18] net: Clear skb->tstamp only on the forwarding path Jesus Sanchez-Palencia
2018-03-07 16:59 ` Willem de Bruijn
2018-03-07 22:03 ` Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 03/18] posix-timers: Add CLOCKID_INVALID mask Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 04/18] net: Add a new socket option for a future transmit time Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 05/18] net: ipv4: raw: Hook into time based transmission Jesus Sanchez-Palencia
2018-03-07 17:00 ` Willem de Bruijn
2018-03-07 1:12 ` [RFC v3 net-next 06/18] net: ipv4: udp: " Jesus Sanchez-Palencia
2018-03-07 17:00 ` Willem de Bruijn
2018-03-07 1:12 ` [RFC v3 net-next 07/18] net: packet: " Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params Jesus Sanchez-Palencia
2018-03-07 2:53 ` Eric Dumazet [this message]
2018-03-07 5:24 ` Richard Cochran
2018-03-07 17:01 ` Willem de Bruijn
2018-03-07 17:35 ` Richard Cochran
2018-03-07 17:37 ` Richard Cochran
2018-03-07 17:47 ` Eric Dumazet
2018-03-08 16:44 ` Richard Cochran
2018-03-08 17:56 ` Jesus Sanchez-Palencia
2018-03-21 12:58 ` Thomas Gleixner
2018-03-21 14:59 ` Richard Cochran
2018-03-21 15:11 ` Thomas Gleixner
2018-03-07 21:52 ` Jesus Sanchez-Palencia
2018-03-07 22:45 ` Eric Dumazet
2018-03-07 23:03 ` David Miller
2018-03-08 11:37 ` Miroslav Lichvar
2018-03-08 16:25 ` David Miller
2018-03-07 1:12 ` [RFC v3 net-next 09/18] net: ipv4: raw: Handle remaining txtime parameters Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 10/18] net: ipv4: udp: " Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 11/18] net: packet: " Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 12/18] net/sched: Allow creating a Qdisc watchdog with other clocks Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc Jesus Sanchez-Palencia
2018-03-21 13:46 ` Thomas Gleixner
2018-03-21 22:29 ` Thomas Gleixner
2018-03-22 20:25 ` Jesus Sanchez-Palencia
2018-03-22 22:52 ` Thomas Gleixner
2018-03-24 0:34 ` Jesus Sanchez-Palencia
2018-03-25 11:46 ` Thomas Gleixner
2018-03-27 23:26 ` Jesus Sanchez-Palencia
2018-03-28 7:48 ` Thomas Gleixner
2018-03-28 13:07 ` Henrik Austad
2018-04-09 16:36 ` Jesus Sanchez-Palencia
2018-04-10 12:37 ` Thomas Gleixner
2018-04-10 21:24 ` Jesus Sanchez-Palencia
2018-04-11 20:16 ` Thomas Gleixner
2018-04-11 20:31 ` Ivan Briano
2018-04-11 23:38 ` Jesus Sanchez-Palencia
2018-04-12 15:03 ` Richard Cochran
2018-04-12 15:19 ` Miroslav Lichvar
2018-04-19 10:03 ` Thomas Gleixner
2018-03-22 20:29 ` Jesus Sanchez-Palencia
2018-03-22 22:11 ` Thomas Gleixner
2018-03-22 23:26 ` Jesus Sanchez-Palencia
2018-03-23 8:49 ` Thomas Gleixner
2018-03-23 23:34 ` Jesus Sanchez-Palencia
2018-04-23 18:21 ` Jesus Sanchez-Palencia
2018-04-24 8:50 ` Thomas Gleixner
2018-04-24 13:50 ` David Miller
2018-03-07 1:12 ` [RFC v3 net-next 14/18] net/sched: Add HW offloading capability to TBS Jesus Sanchez-Palencia
2018-03-21 14:22 ` Thomas Gleixner
2018-03-21 15:03 ` Richard Cochran
2018-03-21 16:18 ` Thomas Gleixner
2018-03-22 22:01 ` Jesus Sanchez-Palencia
2018-03-22 23:15 ` Jesus Sanchez-Palencia
2018-03-23 8:51 ` Thomas Gleixner
2018-03-07 1:12 ` [RFC v3 net-next 15/18] igb: Refactor igb_configure_cbs() Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 16/18] igb: Only change Tx arbitration when CBS is on Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 17/18] igb: Refactor igb_offload_cbs() Jesus Sanchez-Palencia
2018-03-07 1:12 ` [RFC v3 net-next 18/18] igb: Add support for TBS offload Jesus Sanchez-Palencia
2018-03-07 5:28 ` [RFC v3 net-next 00/18] Time based packet transmission Richard Cochran
2018-03-08 14:09 ` Henrik Austad
2018-03-08 18:06 ` Jesus Sanchez-Palencia
2018-03-08 22:54 ` Henrik Austad
2018-03-08 23:58 ` Jesus Sanchez-Palencia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520391209.109662.33.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=edumazet@google.com \
--cc=henrik@austad.us \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesus.sanchez-palencia@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.stultz@linaro.org \
--cc=levi.pearson@harman.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=vinicius.gomes@intel.com \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).