netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Blakey <paulb@mellanox.com>
To: Thomas Graf <tgraf@suug.ch>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Yevgeny Kliteynik <kliteyn@mellanox.com>,
	Roi Dayan <roid@mellanox.com>,
	Shahar Klein <shahark@mellanox.com>,
	Mark Bloch <markb@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Matan Barak <matanb@mellanox.com>,
	Paul Blakey <paulb@mellanox.com>
Subject: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion
Date: Wed,  7 Mar 2018 16:00:11 +0200	[thread overview]
Message-ID: <1520431213-61553-1-git-send-email-paulb@mellanox.com> (raw)

On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
but only where the flow group rhash_head was second (or not first)
on the relevant rhashtable bucket list.

The first patch fixes it, and the second one adds a test that show
it is now working.

Paul.

v4 --> v3 changes:
    * Added Herbert Xu's ack (thanks)
    * Removed extra commit tags
v3 --> v2 changes:
    * Added missing fix in rhashtable_lookup_one code path as well.

v2 --> v1 changes:
    * Changed commit messages to better reflect the change

Paul Blakey (2):
  rhashtable: Fix rhlist duplicates insertion
  test_rhashtable: add test case for rhltable with duplicate objects

 include/linux/rhashtable.h |   4 +-
 lib/rhashtable.c           |   4 +-
 lib/test_rhashtable.c      | 134 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 140 insertions(+), 2 deletions(-)

-- 
1.8.4.3

             reply	other threads:[~2018-03-07 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 14:00 Paul Blakey [this message]
2018-03-07 14:00 ` [PATCH net v4 1/2] rhashtable: Fix rhlist duplicates insertion Paul Blakey
2018-03-07 14:00 ` [PATCH net v4 2/2] test_rhashtable: add test case for rhltable with duplicate objects Paul Blakey
2018-03-07 16:23 ` [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion David Miller
2018-03-08  8:01   ` Paul Blakey
2018-03-11  9:16   ` Or Gerlitz
2018-03-12  2:48     ` David Miller
2018-03-12  6:40       ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520431213-61553-1-git-send-email-paulb@mellanox.com \
    --to=paulb@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jiri@mellanox.com \
    --cc=kliteyn@mellanox.com \
    --cc=markb@mellanox.com \
    --cc=matanb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=shahark@mellanox.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).