From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:54452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934327AbeCGT6C (ORCPT ); Wed, 7 Mar 2018 14:58:02 -0500 Message-ID: <1520452680.3126.35.camel@redhat.com> Subject: Re: [for-next V2 12/13] {net,IB}/mlx5: Add flow steering helpers From: Doug Ledford To: Saeed Mahameed , "David S. Miller" Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Leon Romanovsky , Jason Gunthorpe , Aviad Yehezkel , Matan Barak , Boris Pismenny Date: Wed, 07 Mar 2018 14:58:00 -0500 In-Reply-To: <20180307063516.22773-13-saeedm@mellanox.com> References: <20180307063516.22773-1-saeedm@mellanox.com> <20180307063516.22773-13-saeedm@mellanox.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-3Uo3AsMHI5o0uimegWu3" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-3Uo3AsMHI5o0uimegWu3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2018-03-06 at 22:35 -0800, Saeed Mahameed wrote: > diff --git a/include/linux/mlx5/fs_helpers.h b/include/linux/mlx5/fs_help= ers.h > new file mode 100644 > index 000000000000..7b476bbae731 > --- /dev/null > +++ b/include/linux/mlx5/fs_helpers.h > @@ -0,0 +1,134 @@ > +/* > + * Copyright (c) 2018, Mellanox Technologies. All rights reserved. > + * > + * This software is available to you under a choice of one of two > + * licenses. You may choose to be licensed under the terms of the GNU > + * General Public License (GPL) Version 2, available from the file > + * COPYING in the main directory of this source tree, or the > + * OpenIB.org BSD license below: > + * > + * Redistribution and use in source and binary forms, with or > + * without modification, are permitted provided that the following > + * conditions are met: > + * > + * - Redistributions of source code must retain the above > + * copyright notice, this list of conditions and the following > + * disclaimer. > + * > + * - Redistributions in binary form must reproduce the above > + * copyright notice, this list of conditions and the following > + * disclaimer in the documentation and/or other materials > + * provided with the distribution. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + */ > + Nit: I would prefer a license identifier line followed by just the copyright tag, not the full boiler plate. --=20 Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --=-3Uo3AsMHI5o0uimegWu3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlqgREgACgkQuCajMw5X L91avA//ahmmaNfR0rNduEiI6+ZKwnSOOdIfcN1mU9XUixTl8ubAbHFkuYPUTy0P uND1SOrwt5cEdXoBr9XDA/xzxGTZeLHh0hUmbyTELN4nHeIiXG963FWKUlORHopz 10befgHyBKgyTdJYaWKD5vp3GxmP93JlmW+ClVtyrMTFCbqCZpKeTWp9M4KfnAC2 XTQ1lSe8azHbnIZgaeHv63Hq82IHo224ebyJSl8u1f2WCQMRqpbWsIGqp0U0F3x4 DK9/eNdFoDtnKnznLv7aaveA8CHMNhZHpFL9PTEWdS49A2Y4WFmR5erq+uEY+LWq uSvy2P6YQq5PNpROv21i2koPyuNlhVSOK+hxhIT4GmeNqo9ZeX1BquYWAy48YZNu 0xgM4TqVNyGpvqpYaA5/XMvTWJ0+r/ziGc5x5BlM2Hftkr9MQKL8lbNy4wz9nH3D jr4NAlEiZXrRxnb2VgWIv/z70uo0i4hFryuDxyhfZmptgpq/FF7o7FejDGvMbntU Mrk3dea9nsmVC4mNigP+6zovZAASSm/Nf8OodzKQYvJriUCzY0HfFj9vXkFcOhqg qqElBv1gVl+Q/RptigXDEg1GAmmAvqKcDuoxuR0LBTOJtOFobSh/NPAuNPZd7pgA 2Etye7LyvSrNNN889VBeQGOKlouSfoBfz0z690WwjfNpOt7OUJM= =bXb7 -----END PGP SIGNATURE----- --=-3Uo3AsMHI5o0uimegWu3--