From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:49237 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbeCGU5s (ORCPT ); Wed, 7 Mar 2018 15:57:48 -0500 Message-ID: <1520456266.3126.56.camel@redhat.com> Subject: Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1 From: Doug Ledford To: David Miller , saeedm@mellanox.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, leonro@mellanox.com, jgg@mellanox.com, aviadye@mellanox.com, matanb@mellanox.com, borisp@mellanox.com Date: Wed, 07 Mar 2018 15:57:46 -0500 In-Reply-To: <1520455310.3126.53.camel@redhat.com> References: <20180307063516.22773-1-saeedm@mellanox.com> <20180307.153131.2118921003156719971.davem@davemloft.net> <1520455310.3126.53.camel@redhat.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-gfVgTFVrfzGIhBkTtPNC" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-gfVgTFVrfzGIhBkTtPNC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2018-03-07 at 15:41 -0500, Doug Ledford wrote: > On Wed, 2018-03-07 at 15:31 -0500, David Miller wrote: > > From: Saeed Mahameed > > Date: Tue, 6 Mar 2018 22:35:03 -0800 > >=20 > > > This series includes shared code updates for mlx5 core driver for bot= h > > > netdev and rdma subsystems. This series should be pulled to both > > > trees so we can continue netdev and rdma specific submissions separat= ely. > > >=20 > > > For more information please see tag log below. > > >=20 > > > The series doesn't cause any conflict with the latest mlx5 rc fixes. > > >=20 > > > v1->v2: > > > - Drop sparse fixes patch > > > - Updated commit message of "net/mlx5: Add has_tag to mlx5_flow_act= " > > > - Add const to static mlx5_flow_cmd structs where needed. > >=20 > > Pulled, thanks Saeed. >=20 > Thanks, pulled here as well. >=20 Just FYI, My .config might have been in an unreasonable state (I had jumped from for-next to for-rc, built a kernel which ran a make oldconfig, then jumped back to for-next and tried to build with this series applied but without making any changes to the .config file), but I got a build error. My .config had both innova and the new ipsec accelerator turned off or something like that, and I got this error: CC [M] drivers/net/ethernet/mellanox/mlx5/core/en_main.o drivers/net/ethernet/mellanox/mlx5/core/fs_core.c: In function =E2=80=98mlx5_init_fs=E2=80=99: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2645:6: error: implicit declaration of function =E2=80=98mlx5_accel_ipsec_device_caps=E2= =80=99; did you mean =E2=80=98mlx5_accel_ipsec_cleanup=E2=80=99? [-Werror=3Dimplicit-functi= on-declaration] if (mlx5_accel_ipsec_device_caps(steering->dev) & ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ mlx5_accel_ipsec_cleanup CC [M] drivers/net/ethernet/silan/sc92031.o CC [M] drivers/w1/slaves/w1_smem.o CC [M] drivers/net/ethernet/mellanox/mlx5/core/en_common.o CC [M] drivers/net/ethernet/sfc/falcon/nic.o drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2646:6: error: =E2=80=98MLX5_ACCEL_IPSEC_DEVICE=E2=80=99 undeclared (first use in this fun= ction); did you mean =E2=80=98__MLX5_ACCEL_IPSEC_H__=E2=80=99? MLX5_ACCEL_IPSEC_DEVICE) { ^~~~~~~~~~~~~~~~~~~~~~~ __MLX5_ACCEL_IPSEC_H__ drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2646:6: note: each undeclared identifier is reported only once for each function it appears in CC [M] drivers/w1/w1.o Running make config and enabling innova support and ipsec accelerator support fixed it. --=20 Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --=-gfVgTFVrfzGIhBkTtPNC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlqgUkoACgkQuCajMw5X L90Clw//RUp4E3BolTabY44+2loBW/jlENn82cgKkq+K9NpSOSJfuIz33zUMzfSw tHP4lvwCkLmKb1XFMDN6E2y3aL1jHToJtNCVhQiM4DQRp4e7+DUAyxk5WO4Qc4x6 5135M6mM2UjmCgL8ICAwKbgDr1ZjI5pjeHfsTq747DjW57UJqaeb/FKLF4ZFer0x STDKCh+rgNy8GsNAOyTFahoaBKSajiwqT/wNpdQzlbgTim5r7QW4rFvcxmhCqCYQ j8GHq3PbsctR1Sqw/0T6qcV7Lo1urSmRQsmx6ndnaNujMHg3dg794E6FsZxYpK7V RR2/dKit71vjTH54UPB5+2eO0Onn2HTt9NkI4Kxw9zFnHQDBPqkX38ssa5CfLt2f uQRPd0LQoXoCkzN5vzpfZIpR7AVMovcWSzT4f7nH/rfY8/T45jkG9jNRDzuxxXoI yWrLV413oHMbmtGiR/ty/p6bHuls02ywfg2AoUgRx/jvhHREtL7PImyKW1mgitZv 21/GwvXh+Gy7c2sVGuPn+581rNyvdEtBnA0JpzpzG4q9N3iZ4HMj1rhJKL4/b/hC lyf3ufSwbKRX7EmRhin9LJ9++Xzsqwz7tAoUNXLhYzUUDHc/Rf4wuTZekyPaqFqm LkgKlZxzum/QQRiA4JfWrak9FQdcbrB/2ETrcSNhiuNQ3XeOc5c= =ut+c -----END PGP SIGNATURE----- --=-gfVgTFVrfzGIhBkTtPNC--