From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f42.google.com ([74.125.83.42]:37616 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754039AbeCGWBV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 17:01:21 -0500
Received: by mail-pg0-f42.google.com with SMTP id y26so1422797pgv.4
        for <netdev@vger.kernel.org>; Wed, 07 Mar 2018 14:01:20 -0800 (PST)
Message-ID: <1520460079.109662.57.camel@gmail.com>
Subject: Re: [PATCH net 5/5] tcp: send real dupACKs by locking advertized
 window for non-SACK flows
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@helsinki.fi>
Cc: Netdev <netdev@vger.kernel.org>
Date: Wed, 07 Mar 2018 14:01:19 -0800
In-Reply-To: <alpine.DEB.2.20.1803072229380.30307@whs-18.cs.helsinki.fi>
References: <1520427569-14365-1-git-send-email-ilpo.jarvinen@helsinki.fi>
           <1520427569-14365-6-git-send-email-ilpo.jarvinen@helsinki.fi>
          <1520438302.109662.42.camel@gmail.com>
          <alpine.DEB.2.20.1803072055160.30307@whs-18.cs.helsinki.fi>
         <1520453637.109662.53.camel@gmail.com>
         <alpine.DEB.2.20.1803072229380.30307@whs-18.cs.helsinki.fi>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2018-03-07 at 23:39 +0200, Ilpo Järvinen wrote:
> 
> The problem I'm trying to fix is due to window increasing (of
> course, 
> dupacks could also be masked because of decrease but that's something
> I've never seen to occur in practice) so I tried to make you happy
> and 
> change my fix to do "never increase, always decrease". However, it
> turns 
> out that even pre-fixed code implements "never decrease" not "always 
> decrease" like you thought:

If this was the case, your patch would not be needed.

So really try to add more information in the changelog so that your
patch makes sense to me, and really explains why it is safe.

This kind of information should be recorded in git history, not in mail
archives.

Thanks !