* [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast
@ 2018-03-09 13:25 Mohammed Gamal
2018-03-09 18:37 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Mohammed Gamal @ 2018-03-09 13:25 UTC (permalink / raw)
To: netdev
Cc: otubo, sthemmin, linux-kernel, devel, vkuznets, Mohammed Gamal,
davem
Commit 009f766 intended to filter multicast/broadcast, however
the NDIS filter wasn't set properly in non-promiscuous modes,
which resulted in issues like DHCP timeouts.
This patch sets the filter flags correctly.
Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
drivers/net/hyperv/rndis_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 8927c48..411a3ae 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -861,9 +861,9 @@ static void rndis_set_multicast(struct work_struct *w)
filter = NDIS_PACKET_TYPE_PROMISCUOUS;
} else {
if (flags & IFF_ALLMULTI)
- flags |= NDIS_PACKET_TYPE_ALL_MULTICAST;
+ filter |= NDIS_PACKET_TYPE_ALL_MULTICAST;
if (flags & IFF_BROADCAST)
- flags |= NDIS_PACKET_TYPE_BROADCAST;
+ filter |= NDIS_PACKET_TYPE_BROADCAST;
}
rndis_filter_set_packet_filter(rdev, filter);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast
[not found] <1520594542-24257-1-git-send-email-mgamal@redhat.com>
@ 2018-03-09 15:16 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-03-09 15:16 UTC (permalink / raw)
To: mgamal; +Cc: netdev, devel, linux-kernel, sthemmin, vkuznets, otubo
From: Mohammed Gamal <mgamal@redhat.com>
Date: Fri, 9 Mar 2018 12:22:22 +0100
> Commit 009f766 intended to filter multicast/broadcast, however
> it did cause DHCP timeouts. A closer look showed that the filters
> were not set properly causing this issue.
>
> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
This is fixed already in the net tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast
2018-03-09 13:25 [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast Mohammed Gamal
@ 2018-03-09 18:37 ` Sergei Shtylyov
2018-03-09 18:38 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2018-03-09 18:37 UTC (permalink / raw)
To: Mohammed Gamal, netdev
Cc: devel, linux-kernel, sthemmin, davem, vkuznets, otubo
Hello!
On 03/09/2018 04:25 PM, Mohammed Gamal wrote:
> Commit 009f766 intended to filter multicast/broadcast, however
At least 12 digits needed here, and the summary line too, just like you do
for the Fixes: tag.
> the NDIS filter wasn't set properly in non-promiscuous modes,
> which resulted in issues like DHCP timeouts.
> This patch sets the filter flags correctly.
>
> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast
2018-03-09 18:37 ` Sergei Shtylyov
@ 2018-03-09 18:38 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-03-09 18:38 UTC (permalink / raw)
To: Mohammed Gamal, netdev
Cc: devel, linux-kernel, sthemmin, davem, vkuznets, otubo
On 03/09/2018 09:37 PM, Sergei Shtylyov wrote:
>> Commit 009f766 intended to filter multicast/broadcast, however
>
> At least 12 digits needed here, and the summary line too, just like you do
> for the Fixes: tag.
>
>> the NDIS filter wasn't set properly in non-promiscuous modes,
>> which resulted in issues like DHCP timeouts.
>> This patch sets the filter flags correctly.
>>
>> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
12 digits needed here as well.
>>
>> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-09 18:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-09 13:25 [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast Mohammed Gamal
2018-03-09 18:37 ` Sergei Shtylyov
2018-03-09 18:38 ` Sergei Shtylyov
[not found] <1520594542-24257-1-git-send-email-mgamal@redhat.com>
2018-03-09 15:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).