From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:46830 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbeCLVhx (ORCPT ); Mon, 12 Mar 2018 17:37:53 -0400 Received: by mail-wr0-f196.google.com with SMTP id m12so17175539wrm.13 for ; Mon, 12 Mar 2018 14:37:53 -0700 (PDT) Message-ID: <1520890670.31389.1.camel@debian.org> Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" From: Luca Boccassi To: Stephen Hemminger , green@msu.ru Cc: netdev@vger.kernel.org Date: Mon, 12 Mar 2018 21:37:50 +0000 In-Reply-To: <20180312210301.12757-1-stephen@networkplumber.org> References: <20180312210301.12757-1-stephen@networkplumber.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-1O3WzSUH3SF8bFrXFfQu" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-1O3WzSUH3SF8bFrXFfQu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: > This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. >=20 > Debian maintainer found that basic command: > # ip route flush all > No longer worked as expected which breaks user scripts and > expectations. It no longer flushed all IPv4 routes. >=20 > Reported-by: Luca Boccassi > Signed-off-by: Stephen Hemminger > --- > =C2=A0ip/iproute.c | 65 ++++++++++++++++++------------------------------ > ------------ > =C2=A0lib/utils.c=C2=A0=C2=A0| 13 ++++++++++++ > =C2=A02 files changed, 32 insertions(+), 46 deletions(-) Tested-by: Luca Boccassi Thanks, solves the problem. I'll backport it to Debian. Alexander, reproducing the issue is quite simple - before that commit, ip route ls all showed all routes, but with the change it started showing only the default table. Same for ip route flush. --=20 Kind regards, Luca Boccassi --=-1O3WzSUH3SF8bFrXFfQu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlqm8y4ACgkQSylmgFB4 UWJ2zwf/YsSV5ZwO4V7BLmfYX8QtmPbWl0PL9cjrv6A5yTk7Wx9iNBA+YGgXdEDV VTBX2Ws/uXkP41PxMS2HFrzAWgRIhc4MLzT5iP3cSF7JEG65TJH7S5QHsujHFiXK 3m5MywtvH/5VSNELdSZaIlOLncRQ1mRW0K3jlbfUkUitFj/npZMf8gCRHfAG6zCk bEOJJXOQGc4zUtwy5TEOJS0uLWHhXJYVIjPZM9JDtYb3TAl9+G2xDjgIeVLBXr6M oeUVOSEwnkS2QA2lNq2hMHWSPMUtn3AifMi/ib5BqfzPm7yuTPe9+Ki245/RgbC/ bLyiA7oeqKNj5B9fYdoaYiAnueZ+VA== =sJHi -----END PGP SIGNATURE----- --=-1O3WzSUH3SF8bFrXFfQu--