From: Oliver Neukum <oneukum@suse.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Bjørn Mork" <bjorn@mork.no>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Andrew F. Davis" <afd@ti.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
Date: Tue, 13 Mar 2018 11:26:57 +0100 [thread overview]
Message-ID: <1520936817.5879.2.camel@suse.com> (raw)
In-Reply-To: <7d45bd0c-5ab2-a2c0-d746-ef2d859eea08@users.sourceforge.net>
Am Dienstag, den 13.03.2018, 08:24 +0100 schrieb SF Markus Elfring:
> >
> > >
> > > Use three values directly for a condition check without assigning them
> > > to intermediate variables.
> >
> > Hi,
> >
> > what is the benefit of this?
>
> I proposed a small source code reduction.
>
> Other software design directions might become more interesting for this use case.
Yes and doing so you killed three meaningful names that tell
us what these checks actually test for. That is not an improvement.
Regards
Oliver
next prev parent reply other threads:[~2018-03-13 10:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 18:22 [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:24 ` [PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:41 ` Joe Perches
2018-03-10 18:48 ` Andy Shevchenko
2018-03-10 18:26 ` [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables " SF Markus Elfring
2018-03-12 10:03 ` Oliver Neukum
2018-03-13 7:24 ` [2/2] " SF Markus Elfring
2018-03-13 10:26 ` Oliver Neukum [this message]
2018-03-10 19:17 ` [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520936817.5879.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).