From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:43052 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbeCMMCE (ORCPT ); Tue, 13 Mar 2018 08:02:04 -0400 Received: by mail-wr0-f195.google.com with SMTP id o1so10131457wro.10 for ; Tue, 13 Mar 2018 05:02:04 -0700 (PDT) Message-ID: <1520942521.12414.1.camel@debian.org> Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" From: Luca Boccassi To: Alexander Zubkov , Stephen Hemminger Cc: "netdev@vger.kernel.org" Date: Tue, 13 Mar 2018 12:02:01 +0000 In-Reply-To: <1084221520939138@web32g.yandex.ru> References: <20180312210301.12757-1-stephen@networkplumber.org> <1520890670.31389.1.camel@debian.org> <3677951520930804@web6j.yandex.ru> <1084221520939138@web32g.yandex.ru> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-4ynCYpLb/qs+e+cL9ykO" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-4ynCYpLb/qs+e+cL9ykO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: > Hello again, >=20 > The fun thing is that before the commit "ip route ls all" showed all > routes, but "ip -[4|6] route ls all" showed only default. So it was > broken too, but in other way. > I see parsing of prefix was changed since my patch. So I need several > days to propose fix. I think if "ip route ls [all|any]" shows all > routes and "ip route ls default" shows only default, everybody will > be happy with that? Hi, My only concern is that behaviour of existing commands that have been in releases is not changed, otherwise I get bugs raised :-) Thank you for your work! > 13.03.2018, 09:46, "Alexander Zubkov" : > > Hello. > >=20 > > May be the better way would be to change how "all"/"any" argument > > behaves? My original concern was about "default" only. I agree too, > > that "all" or "any" should work for all routes. But not for the > > default. > >=20 > > 12.03.2018, 22:37, "Luca Boccassi" : > > > =C2=A0On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: > > > > =C2=A0=C2=A0This reverts commit 9135c4d6037ff9f1818507bac0049fc44db= 8c3d2. > > > >=20 > > > > =C2=A0=C2=A0Debian maintainer found that basic command: > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# ip ro= ute flush all > > > > =C2=A0=C2=A0No longer worked as expected which breaks user scripts = and > > > > =C2=A0=C2=A0expectations. It no longer flushed all IPv4 routes. > > > >=20 > > > > =C2=A0=C2=A0Reported-by: Luca Boccassi > > > > =C2=A0=C2=A0Signed-off-by: Stephen Hemminger > > > > =C2=A0=C2=A0--- > > > > =C2=A0=C2=A0=C2=A0ip/iproute.c | 65 ++++++++++++++++++-------------= --------- > > > > -------- > > > > =C2=A0=C2=A0------------ > > > > =C2=A0=C2=A0=C2=A0lib/utils.c=C2=A0=C2=A0| 13 ++++++++++++ > > > > =C2=A0=C2=A0=C2=A02 files changed, 32 insertions(+), 46 deletions(-= ) > > >=20 > > > =C2=A0Tested-by: Luca Boccassi > > >=20 > > > =C2=A0Thanks, solves the problem. I'll backport it to Debian. > > >=20 > > > =C2=A0Alexander, reproducing the issue is quite simple - before that > > > commit, > > > =C2=A0ip route ls all showed all routes, but with the change it > > > started > > > =C2=A0showing only the default table. Same for ip route flush. > > >=20 > > > =C2=A0-- > > > =C2=A0Kind regards, > > > =C2=A0Luca Boccassi --=20 Kind regards, Luca Boccassi --=-4ynCYpLb/qs+e+cL9ykO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlqnvbkACgkQSylmgFB4 UWJf7wf/bVgRbYEwEmMKMp+GOLqgLuIJ87DueVy9SvXEpTGTvAq9wOnb9EY9egPw 7DYNXGzx7AjCpJHINdRrxT/9FKOlkDunlKd/+QG0o0AOFcdpOxRbEjvhNPj6Px0w D9XqtBEg8RFfs3l868wk8T6osEJj1GTGeh++B8TmYTaYvj45iFtlMvppp2ITry4b lEdgzy6OBjvksD4PfBa+ozSYLkPCz4/cIPhKzfJVTUDMaY1UMANnbZ2d2ieABUpQ H8rU4veuc/Yt1EEnjwN4uld9x2XBGQ1ZuFsHOSz+ODuQ2Gcp/ynS2H9SRIu8MhQ5 m4BSxCRY+4sidjr8I0SwJl2pQjBvQg== =8bnw -----END PGP SIGNATURE----- --=-4ynCYpLb/qs+e+cL9ykO--