From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:38572 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbeCMUPk (ORCPT ); Tue, 13 Mar 2018 16:15:40 -0400 Received: by mail-wr0-f194.google.com with SMTP id l8so2221979wrg.5 for ; Tue, 13 Mar 2018 13:15:40 -0700 (PDT) Message-ID: <1520972137.12414.9.camel@debian.org> Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" From: Luca Boccassi To: Alexander Zubkov , Stephen Hemminger Cc: "netdev@vger.kernel.org" Date: Tue, 13 Mar 2018 20:15:37 +0000 In-Reply-To: <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru> References: <20180312210301.12757-1-stephen@networkplumber.org> <1520890670.31389.1.camel@debian.org> <3677951520930804@web6j.yandex.ru> <1084221520939138@web32g.yandex.ru> <1520942521.12414.1.camel@debian.org> <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wq+mQQvdfs5/1EhfpdmY" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-wq+mQQvdfs5/1EhfpdmY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2018-03-13 at 21:12 +0100, Alexander Zubkov wrote: > Hi, >=20 > I just realized that you need patch for v4.15.0, which is easier to > do. > I'll send it as separate message now. I will make patch for the > master=C2=A0 > branch, but later. Thanks but don't worry about 4.15 - Stephen's revert will be enough for now. I'm going to push 4.16 as soon as it's out anyway, so you can just do the changes for master if you wish. > On 13.03.2018 13:02, Luca Boccassi wrote: > > On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: > > > Hello again, > > >=20 > > > The fun thing is that before the commit "ip route ls all" showed > > > all > > > routes, but "ip -[4|6] route ls all" showed only default. So it > > > was > > > broken too, but in other way. > > > I see parsing of prefix was changed since my patch. So I need > > > several > > > days to propose fix. I think if "ip route ls [all|any]" shows all > > > routes and "ip route ls default" shows only default, everybody > > > will > > > be happy with that? > >=20 > > Hi, > >=20 > > My only concern is that behaviour of existing commands that have > > been > > in releases is not changed, otherwise I get bugs raised :-) > >=20 > > Thank you for your work! > >=20 > > > 13.03.2018, 09:46, "Alexander Zubkov" : > > > > Hello. > > > >=20 > > > > May be the better way would be to change how "all"/"any" > > > > argument > > > > behaves? My original concern was about "default" only. I agree > > > > too, > > > > that "all" or "any" should work for all routes. But not for the > > > > default. > > > >=20 > > > > 12.03.2018, 22:37, "Luca Boccassi" : > > > > > =C2=A0=C2=A0On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger = wrote: > > > > > > =C2=A0=C2=A0=C2=A0This reverts commit > > > > > > 9135c4d6037ff9f1818507bac0049fc44db8c3d2. > > > > > >=20 > > > > > > =C2=A0=C2=A0=C2=A0Debian maintainer found that basic command: > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0# ip route flush all > > > > > > =C2=A0=C2=A0=C2=A0No longer worked as expected which breaks use= r scripts > > > > > > and > > > > > > =C2=A0=C2=A0=C2=A0expectations. It no longer flushed all IPv4 r= outes. > > > > > >=20 > > > > > > =C2=A0=C2=A0=C2=A0Reported-by: Luca Boccassi > > > > > > =C2=A0=C2=A0=C2=A0Signed-off-by: Stephen Hemminger > > > > > .org> > > > > > > =C2=A0=C2=A0=C2=A0--- > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0ip/iproute.c | 65 ++++++++++++++++++---= ---------------- > > > > > > --- > > > > > > -------- > > > > > > =C2=A0=C2=A0=C2=A0------------ > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0lib/utils.c=C2=A0=C2=A0| 13 +++++++++++= + > > > > > > =C2=A0=C2=A0=C2=A0=C2=A02 files changed, 32 insertions(+), 46 d= eletions(-) > > > > >=20 > > > > > =C2=A0=C2=A0Tested-by: Luca Boccassi > > > > >=20 > > > > > =C2=A0=C2=A0Thanks, solves the problem. I'll backport it to Debia= n. > > > > >=20 > > > > > =C2=A0=C2=A0Alexander, reproducing the issue is quite simple - be= fore > > > > > that > > > > > commit, > > > > > =C2=A0=C2=A0ip route ls all showed all routes, but with the chang= e it > > > > > started > > > > > =C2=A0=C2=A0showing only the default table. Same for ip route flu= sh. > > > > >=20 > > > > > =C2=A0=C2=A0-- > > > > > =C2=A0=C2=A0Kind regards, > > > > > =C2=A0=C2=A0Luca Boccassi >=20 >=20 --=20 Kind regards, Luca Boccassi --=-wq+mQQvdfs5/1EhfpdmY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlqoMWkACgkQSylmgFB4 UWItDAf+LC5U6nX9JRyqHuAN1T11ydsY7ecceVBfX5k2SWDuj18hr6b3/ZXEjtzz TxblshSNqyFApQjhDxpWixExW4bb/lORuisARFA450xNwVVOKzn25WTxx5zCdajB IlCtO6IBjKJUihztgHVddQbsPj1BZJSTxDcw2MrGRVZujbhMT3vs11ydabVymOWW Ev2S0lxJUyCmB2FZJyyBZoOlhxcRrGdmq010EunWeWkvpLLM9/GLeo+/up3cIu+W PmgropCIfXLKHqIZ3+xong3v2W9gm4Rql+A9P8nh0hyWjebd+3tS+scLYt5MIeEk FXsQjkP5voWKI0bJSZ/qnAJ8J6GKoQ== =gqKE -----END PGP SIGNATURE----- --=-wq+mQQvdfs5/1EhfpdmY--