From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:15572 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbeCMUmq (ORCPT ); Tue, 13 Mar 2018 16:42:46 -0400 From: "Venkataramanan, Anirudh" To: "stephen@networkplumber.org" CC: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support Date: Tue, 13 Mar 2018 20:42:45 +0000 Message-ID: <1520973763.696.33.camel@intel.com> References: <20180309172136.9073-1-anirudh.venkataramanan@intel.com> <20180309172136.9073-13-anirudh.venkataramanan@intel.com> <20180310084243.4584ccd9@xeon-e3> In-Reply-To: <20180310084243.4584ccd9@xeon-e3> Content-Language: en-US Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-2xrdAn5IGQci4cz6Brfb" MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-2xrdAn5IGQci4cz6Brfb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2018-03-10 at 08:42 -0800, Stephen Hemminger wrote: > On Fri, 9 Mar 2018 09:21:33 -0800 > Anirudh Venkataramanan wrote: >=20 > > + /* VSI stats */ > > + struct rtnl_link_stats64 net_stats; > > + struct rtnl_link_stats64 net_stats_prev; > > + struct ice_eth_stats eth_stats; > > + struct ice_eth_stats eth_stats_prev; >=20 > You also don't need current and previous as separate copies since > previous is only > used while computing the current values. Thanks for the feedback, Stephen. eth_stats_prev is used in ice_update_eth_stats when we update eth_stats. While looking into this though, I found that net_stats_prev field in struct ice_vsi (and consequently *prev_ns and *prev_es pointers in ice_update_vsi_stats) may not be needed. Is this what you meant? Thanks! Ani --=-2xrdAn5IGQci4cz6Brfb Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKkTCCBOsw ggPToAMCAQICEFLpAsoR6ESdlGU4L6MaMLswDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzAzMTkwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA 4LDMgJ3YSVX6A9sE+jjH3b+F3Xa86z3LLKu/6WvjIdvUbxnoz2qnvl9UKQI3sE1zURQxrfgvtP0b Pgt1uDwAfLc6H5eqnyi+7FrPsTGCR4gwDmq1WkTQgNDNXUgb71e9/6sfq+WfCDpi8ScaglyLCRp7 ph/V60cbitBvnZFelKCDBh332S6KG3bAdnNGB/vk86bwDlY6omDs6/RsfNwzQVwo/M3oPrux6y6z yIoRulfkVENbM0/9RrzQOlyK4W5Vk4EEsfW2jlCV4W83QKqRccAKIUxw2q/HoHVPbbETrrLmE6RR Z/+eWlkGWl+mtx42HOgOmX0BRdTRo9vH7yeBowIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFB5pKrTcKP5HGE4hCz+8rBEv8Jj1MA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAKcLNo/2So1Jnoi8G7W5Q6FSPq1fmyKW3 sSDf1amvyHkjEgd25n7MKRHGEmRxxoziPKpcmbfXYU+J0g560nCo5gPF78Wd7ZmzcmCcm1UFFfIx fw6QA19bRpTC8bMMaSSEl8y39Pgwa+HENmoPZsM63DdZ6ziDnPqcSbcfYs8qd/m5d22rpXq5IGVU tX6LX7R/hSSw/3sfATnBLgiJtilVyY7OGGmYKCAS2I04itvSS1WtecXTt9OZDyNbl7LtObBrgMLh ZkpJW+pOR9f3h5VG2S5uKkA7Th9NC9EoScdwQCAIw+UWKbSQ0Isj2UFL7fHKvmqWKVTL98sRzvI3 seNC4DCCBZ4wggSGoAMCAQICEzMAALP4LVwBbNmzBOoAAAAAs/gwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEEwHhcNMTgwMjAzMDE0OTIzWhcNMTkwMTI5MDE0OTIzWjBTMSAwHgYDVQQDExdWZW5rYXRh cmFtYW5hbiwgQW5pcnVkaDEvMC0GCSqGSIb3DQEJARYgYW5pcnVkaC52ZW5rYXRhcmFtYW5hbkBp bnRlbC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC2F7YFS2HtPqZ7g+dbUopN G5+whAsBNHPs7tNMq+vnyqYvAiNaSVgcdIinobimjfXSddhQVNO+FZ5FsH40TiPlzqXCkNVnXnOM OTYvLonxVdcymmi6Qa9bTm6Tkscx4Jhrk7ed9rhEt1rs55uf53Io/Up2bJ/NCUttt0R1zIOMkXXZ v5n2b/QrM6bhVWxZsc8n/dQXTRDtw8fe+UblQMyLG8aNDlcBP+jZKxMQE1B00QMFoxgUh4xhRpqP /LtIk4iBKWhqSRSc0yjVOL2HdVQN8wa1W3Lnsu0znPNFNIBxs9xRpvtjjQ+GIo4gWCOTuSkgqSdZ Q/krdi2WdSpMN/abAgMBAAGjggJDMIICPzAdBgNVHQ4EFgQUjd2Su1q/myoK8Zv2QvQF+wlANAYw HwYDVR0jBBgwFoAUHmkqtNwo/kcYTiELP7ysES/wmPUwZQYDVR0fBF4wXDBaoFigVoZUaHR0cDov L3d3dy5pbnRlbC5jb20vcmVwb3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIw SXNzdWluZyUyMENBJTIwNEEuY3JsMIGfBggrBgEFBQcBAQSBkjCBjzBpBggrBgEFBQcwAoZdaHR0 cDovL3d3dy5pbnRlbC5jb20vcmVwb3NpdG9yeS9jZXJ0aWZpY2F0ZXMvSW50ZWwlMjBFeHRlcm5h bCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEEuY3J0MCIGCCsGAQUFBzABhhZodHRwOi8vb2Nz cC5pbnRlbC5jb20vMAsGA1UdDwQEAwIHgDA8BgkrBgEEAYI3FQcELzAtBiUrBgEEAYI3FQiGw4x1 hJnlUYP9gSiFjp9TgpHACWeB3r05lfBDAgFkAgEJMB8GA1UdJQQYMBYGCCsGAQUFBwMEBgorBgEE AYI3CgMMMCkGCSsGAQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGCNwoDDDBdBgNVHREE VjBUoDAGCisGAQQBgjcUAgOgIgwgYW5pcnVkaC52ZW5rYXRhcmFtYW5hbkBpbnRlbC5jb22BIGFu aXJ1ZGgudmVua2F0YXJhbWFuYW5AaW50ZWwuY29tMA0GCSqGSIb3DQEBBQUAA4IBAQAFsnnyo3ix 0y3ZEIZIbdGwZankMrMPDVhiZ3PkbuGrNnB5TLDovfHY/tXrU6VQCRVK5yww/QlCXmGedpunyoio 5ZRDV2O1xA/DgA1ezipDRn+o+6DltF9MMyJN1pk1XyT3jTpNVLcuN8oVbIB87BxIhYnXaM0mfRP4 ilWzQ8EgfH9Byhtgryo55jtOLkj21F1t7a5BSrT3zgpmWljWV1tNeiPVZc+dK659cMo/IfNSody5 1+/tbaDk5dKsaLyFYkvUKBPFQvb17VNANyN43R4gpjEqvTOg+VSE/Q8B1o8/FXRgbXi+57SDmfq3 H5ocL66Zcu1tUeNBlpw5DtFFnnoKMYICFzCCAhMCAQEwgZAweTELMAkGA1UEBhMCVVMxCzAJBgNV BAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24x KzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3VpbmcgQ0EgNEECEzMAALP4LVwBbNmz BOoAAAAAs/gwCQYFKw4DAhoFAKBdMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTE4MDMxMzIwNDI0M1owIwYJKoZIhvcNAQkEMRYEFJFl/oU+YTsuCCy+uImnV75uUJM2 MA0GCSqGSIb3DQEBAQUABIIBAGOgBBHAAsJ2IOno7OOv8YSqgDH1rhzu0P+/Q85t76OxcMnkEgDo Y0PurTl1uECiHL19Y9BgkTZ+F/toCEloucLy8NWtz3niYHxFqhEJ7JF1WE/fx2tmjzIaiOrIYUEh oGjpmyxbvFvCGVo8Lh9wtzH1THy8m05iqaDH9IjH/8aybfxAfzDDm3YwvPXEifiLkjOzqRENbOtG pgu8WgkYMPXf0Scj2/2SxhdJqvxqutTmPkahzKjbY4dXMxESuVQZ2801lENWqQD9o6TSWCoxY29t OV2MHJZQ3sMpiZW2LdzwIId2eHJIqQFxFGzZ30SDu0ibxahrbkyPQycLucH4PgcAAAAAAAA= --=-2xrdAn5IGQci4cz6Brfb--