netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [RFC PATCH 0/2] net:setup XPS mapping for each online CPU
Date: Thu, 15 Mar 2018 18:20:31 +0100	[thread overview]
Message-ID: <1521134431.2681.26.camel@redhat.com> (raw)
In-Reply-To: <CANn89iLJOVuN-1j+9_qr_LaU7AE6COHdnp4Rc7fe9p6_s=hCCA@mail.gmail.com>

Hi,

On Thu, 2018-03-15 at 15:59 +0000, Eric Dumazet wrote:
> On Thu, Mar 15, 2018 at 8:51 AM Paolo Abeni <pabeni@redhat.com> wrote:
> > I'm sorry, I do not follow. AFAICS with unconnected sockets without XPS
> > we always hit the netdev_pick_tx()/skb_tx_hash()/skb_flow_dissect()
> > overhead in xmit path.
> 
> Then fix this if you want, instead of fixing one NIC only, or by enforcing
> XPS by all NIC.
> 
> For unconnected sockets, picking the TX queue based on current cpu is good,
> we do not have to enforce ordering as much as possible.
> 
> (pfifo_fast no longer can enforce it anyway)

Thank you for the prompt reply. 

I'm double checking to avoid misinterpretation on my side: are you
suggesting to plug a CPU-based selection logic for unconnected sockets
in netdev_pick_tx() or to cook patches like 2/2 for all the relevant
NICs? 

Thanks!

Paolo

  reply	other threads:[~2018-03-15 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 15:08 [RFC PATCH 0/2] net:setup XPS mapping for each online CPU Paolo Abeni
2018-03-15 15:08 ` [RFC PATCH 1/2] net: introduce netif_set_xps() Paolo Abeni
2018-03-15 15:08 ` [RFC PATCH 2/2] ixgbe: setup XPS via netif_set_xps() Paolo Abeni
2018-03-15 16:43   ` [Intel-wired-lan] " Alexander Duyck
2018-03-15 17:05     ` Paolo Abeni
2018-03-15 17:22       ` Alexander Duyck
2018-03-15 15:31 ` [RFC PATCH 0/2] net:setup XPS mapping for each online CPU Eric Dumazet
2018-03-15 15:51   ` Paolo Abeni
2018-03-15 15:59     ` Eric Dumazet
2018-03-15 17:20       ` Paolo Abeni [this message]
2018-03-15 17:47         ` [Intel-wired-lan] " Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521134431.2681.26.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).