From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:31137 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbeCOS1x (ORCPT ); Thu, 15 Mar 2018 14:27:53 -0400 From: "Venkataramanan, Anirudh" To: "shannon.nelson@oracle.com" , "intel-wired-lan@lists.osuosl.org" CC: "netdev@vger.kernel.org" Subject: Re: [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization Date: Thu, 15 Mar 2018 18:27:50 +0000 Message-ID: <1521138469.15392.0.camel@intel.com> References: <20180309172136.9073-1-anirudh.venkataramanan@intel.com> <20180309172136.9073-4-anirudh.venkataramanan@intel.com> <657f1de9-9727-6b01-1f79-957db6ef8852@oracle.com> <1521065151.696.91.camel@intel.com> In-Reply-To: Content-Language: en-US Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-giGjhBwOAPZZbyTQdSnU" MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: --=-giGjhBwOAPZZbyTQdSnU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-03-15 at 10:00 -0700, Shannon Nelson wrote: > On 3/14/2018 3:05 PM, Venkataramanan, Anirudh wrote: > > On Mon, 2018-03-12 at 19:05 -0700, Shannon Nelson wrote: > > > On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: >=20 >=20 > > > > + > > > > +/** > > > > + * ice_read_sr_aq - Read Shadow RAM. > > > > + * @hw: pointer to the HW structure > > > > + * @offset: offset in words from module start > > > > + * @words: number of words to read > > > > + * @data: buffer for words reads from Shadow RAM > > > > + * @last_command: tells the AdminQ that this is the last > > > > command > > > > + * > > > > + * Reads 16-bit word buffers from the Shadow RAM using the > > > > admin > > > > command. > > > > + */ > > > > +static enum ice_status > > > > +ice_read_sr_aq(struct ice_hw *hw, u32 offset, u16 words, u16 > > > > *data, > > > > + bool last_command) > > > > +{ > > > > + enum ice_status status; > > > > + > > > > + status =3D ice_check_sr_access_params(hw, offset, > > > > words); > > > > + if (!status) > > > > + status =3D ice_aq_read_nvm(hw, 0, 2 * offset, 2 > > > > * > > > > words, data, > > >=20 > > > Why the doubling of offset and words? If this is some general > > > adjustment made for the AQ interface, it should be made in > > > ice_aq_read_nvm(). If not, then some explanation is needed here. > >=20 > > ice_read_sr_aq expects a word offset and size in words. The > > ice_aq_read_nvm interface expects offset and size in bytes. The > > doubling is a conversion from word offset/size to byte offset/size. >=20 > In that case, this might be a good place for a small comment for > readers=20 > like me who don't have the spec available. Sure thing! :-) >=20 > sln >=20 --=-giGjhBwOAPZZbyTQdSnU Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKkTCCBOsw ggPToAMCAQICEFLpAsoR6ESdlGU4L6MaMLswDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzAzMTkwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA 4LDMgJ3YSVX6A9sE+jjH3b+F3Xa86z3LLKu/6WvjIdvUbxnoz2qnvl9UKQI3sE1zURQxrfgvtP0b Pgt1uDwAfLc6H5eqnyi+7FrPsTGCR4gwDmq1WkTQgNDNXUgb71e9/6sfq+WfCDpi8ScaglyLCRp7 ph/V60cbitBvnZFelKCDBh332S6KG3bAdnNGB/vk86bwDlY6omDs6/RsfNwzQVwo/M3oPrux6y6z yIoRulfkVENbM0/9RrzQOlyK4W5Vk4EEsfW2jlCV4W83QKqRccAKIUxw2q/HoHVPbbETrrLmE6RR Z/+eWlkGWl+mtx42HOgOmX0BRdTRo9vH7yeBowIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFB5pKrTcKP5HGE4hCz+8rBEv8Jj1MA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAKcLNo/2So1Jnoi8G7W5Q6FSPq1fmyKW3 sSDf1amvyHkjEgd25n7MKRHGEmRxxoziPKpcmbfXYU+J0g560nCo5gPF78Wd7ZmzcmCcm1UFFfIx fw6QA19bRpTC8bMMaSSEl8y39Pgwa+HENmoPZsM63DdZ6ziDnPqcSbcfYs8qd/m5d22rpXq5IGVU tX6LX7R/hSSw/3sfATnBLgiJtilVyY7OGGmYKCAS2I04itvSS1WtecXTt9OZDyNbl7LtObBrgMLh ZkpJW+pOR9f3h5VG2S5uKkA7Th9NC9EoScdwQCAIw+UWKbSQ0Isj2UFL7fHKvmqWKVTL98sRzvI3 seNC4DCCBZ4wggSGoAMCAQICEzMAALP4LVwBbNmzBOoAAAAAs/gwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEEwHhcNMTgwMjAzMDE0OTIzWhcNMTkwMTI5MDE0OTIzWjBTMSAwHgYDVQQDExdWZW5rYXRh cmFtYW5hbiwgQW5pcnVkaDEvMC0GCSqGSIb3DQEJARYgYW5pcnVkaC52ZW5rYXRhcmFtYW5hbkBp bnRlbC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC2F7YFS2HtPqZ7g+dbUopN G5+whAsBNHPs7tNMq+vnyqYvAiNaSVgcdIinobimjfXSddhQVNO+FZ5FsH40TiPlzqXCkNVnXnOM OTYvLonxVdcymmi6Qa9bTm6Tkscx4Jhrk7ed9rhEt1rs55uf53Io/Up2bJ/NCUttt0R1zIOMkXXZ v5n2b/QrM6bhVWxZsc8n/dQXTRDtw8fe+UblQMyLG8aNDlcBP+jZKxMQE1B00QMFoxgUh4xhRpqP /LtIk4iBKWhqSRSc0yjVOL2HdVQN8wa1W3Lnsu0znPNFNIBxs9xRpvtjjQ+GIo4gWCOTuSkgqSdZ Q/krdi2WdSpMN/abAgMBAAGjggJDMIICPzAdBgNVHQ4EFgQUjd2Su1q/myoK8Zv2QvQF+wlANAYw HwYDVR0jBBgwFoAUHmkqtNwo/kcYTiELP7ysES/wmPUwZQYDVR0fBF4wXDBaoFigVoZUaHR0cDov L3d3dy5pbnRlbC5jb20vcmVwb3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIw SXNzdWluZyUyMENBJTIwNEEuY3JsMIGfBggrBgEFBQcBAQSBkjCBjzBpBggrBgEFBQcwAoZdaHR0 cDovL3d3dy5pbnRlbC5jb20vcmVwb3NpdG9yeS9jZXJ0aWZpY2F0ZXMvSW50ZWwlMjBFeHRlcm5h bCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEEuY3J0MCIGCCsGAQUFBzABhhZodHRwOi8vb2Nz cC5pbnRlbC5jb20vMAsGA1UdDwQEAwIHgDA8BgkrBgEEAYI3FQcELzAtBiUrBgEEAYI3FQiGw4x1 hJnlUYP9gSiFjp9TgpHACWeB3r05lfBDAgFkAgEJMB8GA1UdJQQYMBYGCCsGAQUFBwMEBgorBgEE AYI3CgMMMCkGCSsGAQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGCNwoDDDBdBgNVHREE VjBUoDAGCisGAQQBgjcUAgOgIgwgYW5pcnVkaC52ZW5rYXRhcmFtYW5hbkBpbnRlbC5jb22BIGFu aXJ1ZGgudmVua2F0YXJhbWFuYW5AaW50ZWwuY29tMA0GCSqGSIb3DQEBBQUAA4IBAQAFsnnyo3ix 0y3ZEIZIbdGwZankMrMPDVhiZ3PkbuGrNnB5TLDovfHY/tXrU6VQCRVK5yww/QlCXmGedpunyoio 5ZRDV2O1xA/DgA1ezipDRn+o+6DltF9MMyJN1pk1XyT3jTpNVLcuN8oVbIB87BxIhYnXaM0mfRP4 ilWzQ8EgfH9Byhtgryo55jtOLkj21F1t7a5BSrT3zgpmWljWV1tNeiPVZc+dK659cMo/IfNSody5 1+/tbaDk5dKsaLyFYkvUKBPFQvb17VNANyN43R4gpjEqvTOg+VSE/Q8B1o8/FXRgbXi+57SDmfq3 H5ocL66Zcu1tUeNBlpw5DtFFnnoKMYICFzCCAhMCAQEwgZAweTELMAkGA1UEBhMCVVMxCzAJBgNV BAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24x KzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3VpbmcgQ0EgNEECEzMAALP4LVwBbNmz BOoAAAAAs/gwCQYFKw4DAhoFAKBdMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTE4MDMxNTE4Mjc0OVowIwYJKoZIhvcNAQkEMRYEFCcrTGKpKXi39pdZa7S7oructUty MA0GCSqGSIb3DQEBAQUABIIBADI0GeookxQ6BTqjNThzPPptM0xqIU/lObnRxigGifSnbfVQcfoV lxsEsdJ8TjfwClJsSfxa0U4aoQEMUowLDP2LAtSuv33Vja5vBXavqmKPdmtnjvqr7B31RlGTZEA7 S8rpNk2uJz744o7TITSI5U94VWIDVqk9QP1A21DcxvOE2o/ZUVeSMzedxHk8lhpZsLp43s6TGMnk USuPcdVQdrHh4NG7wHZJYbDousJjVDLOdLcxtSEW6n3gltHOmu1sWPYmqTlnQkeRvzHQ+y/4cR/z uq5iMc+Tg63thNSwyi41Hb/hM92xqNakpx0pN1VX1HYbrwdpOjcW0E4RXmhe5PwAAAAAAAA= --=-giGjhBwOAPZZbyTQdSnU--