From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751966AbeCOWVQ (ORCPT ); Thu, 15 Mar 2018 18:21:16 -0400 Message-ID: <1521152472.2666.8.camel@redhat.com> Subject: Re: [PATCH net] net/sched: fix NULL dereference in the error path of tcf_vlan_init() From: Davide Caratti To: Jiri Pirko Cc: Cong Wang , "David S. Miller" , netdev@vger.kernel.org, Manish Kurup , Roman Mashak In-Reply-To: <1521124149.2797.11.camel@redhat.com> References: <1d301fb86becf863283ee1be107f17e837ef4255.1521122595.git.dcaratti@redhat.com> <20180315142157.GG2130@nanopsycho> <1521124149.2797.11.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 15 Mar 2018 23:21:12 +0100 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2018-03-15 at 15:29 +0100, Davide Caratti wrote: > On Thu, 2018-03-15 at 15:21 +0100, Jiri Pirko wrote: > ... > > > Acked-by: Jiri Pirko > > thank you for reviewing! > > apparently, also act_tunnel_key seem and act_csum have a similar problem. > I will check and eventually do a followup series this afternoon. > > thank you, > regards hello David, please drop this patch: after some tests, the following TC actions are affected by the same problem: act_vlan act_csum act_tunnel_key act_skbmod act_sample so, I'm posting right now a series that fixes all of them. In act_ife and act_bpf, the problem is potentially there, but we don't see it crashing yet because we don't call tcf_idr_release() on the error path. This is causing the leak of 'index', and will be fixed in another series tomorrow. thank you in advance, regards -- davide