From: Sinan Kaya <okaya@codeaurora.org>
To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org
Subject: [PATCH v7 1/7] net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs
Date: Sun, 25 Mar 2018 10:39:15 -0400 [thread overview]
Message-ID: <1521988761-30344-2-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521988761-30344-1-git-send-email-okaya@codeaurora.org>
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing code to
wmb()
writel_relaxed()
mmiowb()
for multi-arch support.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 9e5264d..b48f761 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -1858,8 +1858,9 @@ static void ql_update_small_bufq_prod_index(struct ql3_adapter *qdev)
qdev->small_buf_release_cnt -= 8;
}
wmb();
- writel(qdev->small_buf_q_producer_index,
- &port_regs->CommonRegs.rxSmallQProducerIndex);
+ writel_relaxed(qdev->small_buf_q_producer_index,
+ &port_regs->CommonRegs.rxSmallQProducerIndex);
+ mmiowb();
}
}
--
2.7.4
next prev parent reply other threads:[~2018-03-25 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 14:39 [PATCH v7 0/7] netdev: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-25 14:39 ` Sinan Kaya [this message]
2018-03-25 14:39 ` [PATCH v7 2/7] qlcnic: " Sinan Kaya
2018-03-25 14:39 ` [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb() Sinan Kaya
2018-03-29 9:17 ` Elior, Ariel
2018-03-29 13:45 ` Sinan Kaya
2018-03-25 14:39 ` [PATCH v7 4/7] bnx2x: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-25 14:39 ` [PATCH v7 5/7] net: qlge: " Sinan Kaya
2018-03-25 14:39 ` [PATCH v7 6/7] bnxt_en: " Sinan Kaya
2018-03-25 20:24 ` Michael Chan
2018-03-25 14:39 ` [PATCH v7 7/7] net: ena: " Sinan Kaya
2018-03-26 16:48 ` [PATCH v7 0/7] netdev: " David Miller
2018-03-27 12:40 ` Sinan Kaya
2018-03-27 14:00 ` David Miller
2018-03-27 14:02 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521988761-30344-2-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).