From mboxrd@z Thu Jan 1 00:00:00 1970 From: NeilBrown Subject: [PATCH 3/6] rhashtable: reset intr when rhashtable_walk_start sees new table Date: Tue, 27 Mar 2018 10:33:04 +1100 Message-ID: <152210718427.11435.17689950338335773862.stgit@noble> References: <152210688405.11435.13010923693146415942.stgit@noble> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Thomas Graf , Herbert Xu Return-path: In-Reply-To: <152210688405.11435.13010923693146415942.stgit@noble> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org The documentation claims that when rhashtable_walk_start_check() detects a resize event, it will rewind back to the beginning of the table. This is not true. We need to set ->slot and ->skip to be zero for it to be true. Signed-off-by: NeilBrown --- lib/rhashtable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 24a57ca494cb..08018198f045 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -733,6 +733,8 @@ int rhashtable_walk_start_check(struct rhashtable_iter *iter) if (!iter->walker.tbl && !iter->end_of_table) { iter->walker.tbl = rht_dereference_rcu(ht->tbl, ht); + iter->slot = 0; + iter->skip = 0; return -EAGAIN; }