From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy
Date: Tue, 27 Mar 2018 23:59:40 +0200 [thread overview]
Message-ID: <1522187980-23072-3-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1522187980-23072-1-git-send-email-andrew@lunn.ch>
VTU miss violations can happen under normal conditions. Don't spam the
kernel log. The statistics counter will indicate it is happening, if
anybody is interested.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/global1_vtu.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/global1_vtu.c b/drivers/net/dsa/mv88e6xxx/global1_vtu.c
index 2cbaf946e7ed..e0f1b4f6e29f 100644
--- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c
+++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c
@@ -547,11 +547,9 @@ static irqreturn_t mv88e6xxx_g1_vtu_prob_irq_thread_fn(int irq, void *dev_id)
chip->ports[spid].vtu_member_violation++;
}
- if (val & MV88E6XXX_G1_VTU_OP_MISS_VIOLATION) {
- dev_err_ratelimited(chip->dev, "VTU miss violation for vid %d, source port %d\n",
- entry.vid, spid);
+ if (val & MV88E6XXX_G1_VTU_OP_MISS_VIOLATION)
chip->ports[spid].vtu_miss_violation++;
- }
+
mutex_unlock(&chip->reg_lock);
return IRQ_HANDLED;
--
2.16.2
next prev parent reply other threads:[~2018-03-27 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 21:59 [PATCH net-next 0/2] Add ATU/VTU statistics Andrew Lunn
2018-03-27 21:59 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics Andrew Lunn
2018-03-28 18:17 ` Florian Fainelli
2018-03-28 19:33 ` Andrew Lunn
2018-03-28 19:57 ` Florian Fainelli
2018-03-27 21:59 ` Andrew Lunn [this message]
2018-03-28 18:11 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy Florian Fainelli
2018-03-28 19:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522187980-23072-3-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).