From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy Date: Tue, 27 Mar 2018 23:59:40 +0200 Message-ID: <1522187980-23072-3-git-send-email-andrew@lunn.ch> References: <1522187980-23072-1-git-send-email-andrew@lunn.ch> Cc: netdev , Andrew Lunn To: David Miller Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:44414 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbeC0WA2 (ORCPT ); Tue, 27 Mar 2018 18:00:28 -0400 In-Reply-To: <1522187980-23072-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: VTU miss violations can happen under normal conditions. Don't spam the kernel log. The statistics counter will indicate it is happening, if anybody is interested. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/global1_vtu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/global1_vtu.c b/drivers/net/dsa/mv88e6xxx/global1_vtu.c index 2cbaf946e7ed..e0f1b4f6e29f 100644 --- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c +++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c @@ -547,11 +547,9 @@ static irqreturn_t mv88e6xxx_g1_vtu_prob_irq_thread_fn(int irq, void *dev_id) chip->ports[spid].vtu_member_violation++; } - if (val & MV88E6XXX_G1_VTU_OP_MISS_VIOLATION) { - dev_err_ratelimited(chip->dev, "VTU miss violation for vid %d, source port %d\n", - entry.vid, spid); + if (val & MV88E6XXX_G1_VTU_OP_MISS_VIOLATION) chip->ports[spid].vtu_miss_violation++; - } + mutex_unlock(&chip->reg_lock); return IRQ_HANDLED; -- 2.16.2