From: Mike Looijmans <mike.looijmans@topic.nl>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andrew@lunn.ch, f.fainelli@gmail.com, robh+dt@kernel.org,
frowand.list@gmail.com, Mike Looijmans <mike.looijmans@topic.nl>
Subject: [PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider
Date: Thu, 29 Mar 2018 07:29:49 +0200 [thread overview]
Message-ID: <1522301389-11034-3-git-send-email-mike.looijmans@topic.nl> (raw)
In-Reply-To: <1522301389-11034-1-git-send-email-mike.looijmans@topic.nl>
Call of_get_nvmem_mac_address() to fetch the MAC address from an nvmem
cell, if one is provided in the device tree. This allows the address to
be stored in an I2C EEPROM device for example.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/net/ethernet/cadence/macb_main.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index e84afcf..eabe14f 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3950,10 +3950,16 @@ static int macb_probe(struct platform_device *pdev)
dev->max_mtu = ETH_DATA_LEN;
mac = of_get_mac_address(np);
- if (mac)
+ if (mac) {
ether_addr_copy(bp->dev->dev_addr, mac);
- else
- macb_get_hwaddr(bp);
+ } else {
+ err = of_get_nvmem_mac_address(np, bp->dev->dev_addr);
+ if (err) {
+ if (err == -EPROBE_DEFER)
+ goto err_out_free_netdev;
+ macb_get_hwaddr(bp);
+ }
+ }
err = of_get_phy_mode(np);
if (err < 0) {
--
1.9.1
next prev parent reply other threads:[~2018-03-29 5:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 14:24 [PATCH] of_net: Implement of_get_nvmem_mac_address helper Mike Looijmans
2018-03-23 15:11 ` Andrew Lunn
2018-03-23 19:20 ` Mike Looijmans
2018-03-23 19:33 ` Florian Fainelli
2018-03-24 16:17 ` Mike Looijmans
2018-03-24 18:53 ` Andrew Lunn
2018-03-25 8:17 ` Mike Looijmans
2018-03-25 21:04 ` Andrew Lunn
2018-03-26 6:54 ` Mike Looijmans
2018-03-23 19:42 ` Andrew Lunn
2018-03-24 16:03 ` Mike Looijmans
2018-03-26 6:41 ` [PATCH v2] " Mike Looijmans
2018-03-26 15:50 ` Andrew Lunn
2018-03-26 18:25 ` Mike Looijmans
2018-03-26 18:41 ` Andrew Lunn
2018-03-26 16:58 ` David Miller
2018-03-26 17:05 ` Florian Fainelli
2018-03-26 18:21 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 0/2] " Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 1/2] " Mike Looijmans
2018-03-27 22:50 ` Florian Fainelli
2018-03-29 5:31 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 2/2] net: macb: Try to retrieve MAC addess from nvmem provider Mike Looijmans
2018-03-28 8:00 ` Nicolas Ferre
2018-03-27 22:43 ` [PATCH v3 0/2] of_net: Implement of_get_nvmem_mac_address helper Andrew Lunn
2018-03-29 5:29 ` [PATCH v4 " Mike Looijmans
2018-03-29 5:29 ` [PATCH v4 1/2] " Mike Looijmans
2018-03-29 5:29 ` Mike Looijmans [this message]
2018-03-30 14:40 ` [PATCH v4 0/2] " David Miller
2018-03-31 17:20 ` Mike Looijmans
2018-03-31 17:27 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522301389-11034-3-git-send-email-mike.looijmans@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).