From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Armin Schindler <mac@melware.de>,
Karsten Keil <isdn@linux-pingi.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ISDN: eicon: message: remove redundant check
Date: Fri, 30 Mar 2018 09:19:19 -0700 [thread overview]
Message-ID: <1522426759.2210.46.camel@perches.com> (raw)
In-Reply-To: <20180330154648.GA13995@embeddedgus>
On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote:
> Check on plci->internal_command is unnecessary.
Probably all of these are unnecessary too:
$ for length in {7..2} ; do \
grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
done
drivers/staging/wilc1000/wilc_wlan.c:691: break;
break;
drivers/media/dvb-frontends/drxd_hard.c:2261: break;
break;
drivers/media/dvb-frontends/drxd_hard.c:2266: break;
break;
drivers/media/usb/gspca/sn9c20x.c:1860: break;
break;
drivers/isdn/i4l/isdn_common.c:624: break;
break;
drivers/isdn/i4l/isdn_common.c:642: break;
break;
drivers/isdn/i4l/isdn_common.c:654: break;
break;
drivers/isdn/hardware/eicon/message.c:13890: break;
break;
sound/usb/mixer_quirks.c:1832: break;
break;
next prev parent reply other threads:[~2018-03-30 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 15:46 [PATCH] ISDN: eicon: message: remove redundant check Gustavo A. R. Silva
2018-03-30 16:19 ` Joe Perches [this message]
2018-03-30 16:32 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522426759.2210.46.camel@perches.com \
--to=joe@perches.com \
--cc=gustavo@embeddedor.com \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).