From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] ISDN: eicon: message: remove redundant check
Date: Fri, 30 Mar 2018 09:19:19 -0700
Message-ID: <1522426759.2210.46.camel@perches.com>
References: <20180330154648.GA13995@embeddedgus>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Armin Schindler <mac@melware.de>,
        Karsten Keil <isdn@linux-pingi.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180330154648.GA13995@embeddedgus>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote:
> Check on plci->internal_command is unnecessary.

Probably all of these are unnecessary too:

$ for length in {7..2} ; do \
    grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
  done
drivers/staging/wilc1000/wilc_wlan.c:691:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2261:				break;
			break;
drivers/media/dvb-frontends/drxd_hard.c:2266:				break;
			break;
drivers/media/usb/gspca/sn9c20x.c:1860:			break;
		break;
drivers/isdn/i4l/isdn_common.c:624:			break;
		break;
drivers/isdn/i4l/isdn_common.c:642:			break;
		break;
drivers/isdn/i4l/isdn_common.c:654:			break;
		break;
drivers/isdn/hardware/eicon/message.c:13890:			break;
		break;
sound/usb/mixer_quirks.c:1832:			break;
		break;