From: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: netdev@vger.kernel.org, trivial@linux.org, davem@davemloft.net,
Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Subject: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
Date: Sun, 1 Apr 2018 22:52:55 +0200 [thread overview]
Message-ID: <1522615975-20952-1-git-send-email-fransmeulenbroeks@gmail.com> (raw)
mdio-bitbang mentioned 10 for both read and write.
However mdio read opcode is 10 and write opcode is 01
Fixed comment.
Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
drivers/net/phy/mdio-bitbang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
index 61a543c..403b085 100644
--- a/drivers/net/phy/mdio-bitbang.c
+++ b/drivers/net/phy/mdio-bitbang.c
@@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int op, u8 phy, u8 reg)
for (i = 0; i < 32; i++)
mdiobb_send_bit(ctrl, 1);
- /* send the start bit (01) and the read opcode (10) or write (10).
+ /* send the start bit (01) and the read opcode (10) or write (01).
Clause 45 operation uses 00 for the start and 11, 10 for
read/write */
mdiobb_send_bit(ctrl, 0);
--
2.7.4
next reply other threads:[~2018-04-01 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 20:52 Frans Meulenbroeks [this message]
2018-04-01 23:43 ` [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang Andrew Lunn
2018-04-02 0:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522615975-20952-1-git-send-email-fransmeulenbroeks@gmail.com \
--to=fransmeulenbroeks@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=trivial@linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox