* [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
@ 2018-04-01 20:52 Frans Meulenbroeks
2018-04-01 23:43 ` Andrew Lunn
2018-04-02 0:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Frans Meulenbroeks @ 2018-04-01 20:52 UTC (permalink / raw)
Cc: netdev, trivial, davem, Frans Meulenbroeks
mdio-bitbang mentioned 10 for both read and write.
However mdio read opcode is 10 and write opcode is 01
Fixed comment.
Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
drivers/net/phy/mdio-bitbang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
index 61a543c..403b085 100644
--- a/drivers/net/phy/mdio-bitbang.c
+++ b/drivers/net/phy/mdio-bitbang.c
@@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int op, u8 phy, u8 reg)
for (i = 0; i < 32; i++)
mdiobb_send_bit(ctrl, 1);
- /* send the start bit (01) and the read opcode (10) or write (10).
+ /* send the start bit (01) and the read opcode (10) or write (01).
Clause 45 operation uses 00 for the start and 11, 10 for
read/write */
mdiobb_send_bit(ctrl, 0);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
2018-04-01 20:52 [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang Frans Meulenbroeks
@ 2018-04-01 23:43 ` Andrew Lunn
2018-04-02 0:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-04-01 23:43 UTC (permalink / raw)
To: Frans Meulenbroeks; +Cc: netdev, trivial, davem
On Sun, Apr 01, 2018 at 10:52:55PM +0200, Frans Meulenbroeks wrote:
> mdio-bitbang mentioned 10 for both read and write.
> However mdio read opcode is 10 and write opcode is 01
> Fixed comment.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
2018-04-01 20:52 [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang Frans Meulenbroeks
2018-04-01 23:43 ` Andrew Lunn
@ 2018-04-02 0:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-04-02 0:57 UTC (permalink / raw)
To: fransmeulenbroeks; +Cc: netdev, trivial
From: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Date: Sun, 1 Apr 2018 22:52:55 +0200
> mdio-bitbang mentioned 10 for both read and write.
> However mdio read opcode is 10 and write opcode is 01
> Fixed comment.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-02 0:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-01 20:52 [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang Frans Meulenbroeks
2018-04-01 23:43 ` Andrew Lunn
2018-04-02 0:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox