From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frans Meulenbroeks Subject: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang. Date: Sun, 1 Apr 2018 22:52:55 +0200 Message-ID: <1522615975-20952-1-git-send-email-fransmeulenbroeks@gmail.com> Cc: netdev@vger.kernel.org, trivial@linux.org, davem@davemloft.net, Frans Meulenbroeks To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:40517 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbeDAUxD (ORCPT ); Sun, 1 Apr 2018 16:53:03 -0400 Received: by mail-wm0-f68.google.com with SMTP id x4so23910095wmh.5 for ; Sun, 01 Apr 2018 13:53:03 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: mdio-bitbang mentioned 10 for both read and write. However mdio read opcode is 10 and write opcode is 01 Fixed comment. Signed-off-by: Frans Meulenbroeks --- drivers/net/phy/mdio-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c index 61a543c..403b085 100644 --- a/drivers/net/phy/mdio-bitbang.c +++ b/drivers/net/phy/mdio-bitbang.c @@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int op, u8 phy, u8 reg) for (i = 0; i < 32; i++) mdiobb_send_bit(ctrl, 1); - /* send the start bit (01) and the read opcode (10) or write (10). + /* send the start bit (01) and the read opcode (10) or write (01). Clause 45 operation uses 00 for the start and 11, 10 for read/write */ mdiobb_send_bit(ctrl, 0); -- 2.7.4