From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer Date: Tue, 3 Apr 2018 10:18:24 +0800 Message-ID: <1522721904.18424.51.camel@mtkswgap22> References: <20180402232414.19671-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vivien Didelot , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, open list , Andrew Lunn To: Florian Fainelli Return-path: In-Reply-To: <20180402232414.19671-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: > We would be passing 0 instead of NULL as the rsp argument to > mt7530_fdb_cmd(), fix that. > Acked-by: Sean Wang BTW, does the part of the commit message should be updated with "passing NULL instead of 0"? > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") > Signed-off-by: Florian Fainelli > --- > drivers/net/dsa/mt7530.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 4e53c5ce23ff..a7f6c0a62fc7 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -917,7 +917,7 @@ mt7530_port_fdb_add(struct dsa_switch *ds, int port, > > mutex_lock(&priv->reg_mutex); > mt7530_fdb_write(priv, vid, port_mask, addr, -1, STATIC_ENT); > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, NULL); > mutex_unlock(&priv->reg_mutex); > > return ret; > @@ -933,7 +933,7 @@ mt7530_port_fdb_del(struct dsa_switch *ds, int port, > > mutex_lock(&priv->reg_mutex); > mt7530_fdb_write(priv, vid, port_mask, addr, -1, STATIC_EMP); > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, NULL); > mutex_unlock(&priv->reg_mutex); > > return ret; > @@ -1293,7 +1293,7 @@ mt7530_setup(struct dsa_switch *ds) > } > > /* Flush the FDB table */ > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, NULL); > if (ret < 0) > return ret; >