From: Johannes Berg <johannes@sipsolutions.net>
To: syzbot <syzbot+230d9e642a85d3fec29c@syzkaller.appspotmail.com>,
davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in add_uevent_var
Date: Tue, 03 Apr 2018 14:34:05 +0200 [thread overview]
Message-ID: <1522758845.2961.3.camel@sipsolutions.net> (raw)
In-Reply-To: <000000000000a010b80568d75018@google.com> (sfid-20180402_080105_275284_9D0A53D3)
On Sun, 2018-04-01 at 23:01 -0700, syzbot wrote:
> So far this crash happened 5 times on net-next, upstream.
> C reproducer: https://syzkaller.appspot.com/x/repro.c?id=6614377067184128
>
Huh, fun. Looks like you're basically creating a new HWSIM radio with an
insanely long name (4k!) and nothing stops you, until we try to generate
an rfkill instance which sends a uevent and only has a 2k buffer for the
environment variables, where we put the name ...
But yeah, we should probably limit the phy name to something sane, I'll
pick 128 and send a patch.
johannes
next prev parent reply other threads:[~2018-04-03 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 6:01 WARNING in add_uevent_var syzbot
2018-04-03 12:34 ` Johannes Berg [this message]
2018-05-07 10:13 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522758845.2961.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+230d9e642a85d3fec29c@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).