From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer Date: Wed, 4 Apr 2018 01:31:51 +0800 Message-ID: <1522776711.12959.1.camel@mtkswgap22> References: <20180402232414.19671-1-f.fainelli@gmail.com> <1522721904.18424.51.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vivien Didelot , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, open list , Andrew Lunn To: Florian Fainelli Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, 2018-04-03 at 10:02 -0700, Florian Fainelli wrote: > On 04/02/2018 07:18 PM, Sean Wang wrote: > > On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: > >> We would be passing 0 instead of NULL as the rsp argument to > >> mt7530_fdb_cmd(), fix that. > >> > > > > Acked-by: Sean Wang > > > > BTW, does the part of the commit message should be updated with "passing > > NULL instead of 0"? > > I don't follow you, the commit message indicates what we were doing > which implies it was wrong and fixes it. Would you want me to reword > that part? thanks for the explanation. the commit message is clear and okay for me now