Netdev List
 help / color / mirror / Atom feed
From: Mohammed Gamal <mgamal@redhat.com>
To: netdev@vger.kernel.org, sthemmin@microsoft.com
Cc: otubo@redhat.com, Mohammed Gamal <mgamal@redhat.com>,
	haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, vkuznets@redhat.com
Subject: [PATCH 1/4] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown
Date: Thu,  5 Apr 2018 21:09:18 +0200	[thread overview]
Message-ID: <1522955361-14704-2-git-send-email-mgamal@redhat.com> (raw)
In-Reply-To: <1522955361-14704-1-git-send-email-mgamal@redhat.com>

When changing network interface settings, Windows guests
older than WS2016 can no longer shutdown. This was addressed
by commit 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order
on older versions"), however the issue also occurs on WS2012
guests that share NVSP protocol versions with WS2016 guests.
Hence we use Windows version directly to differentiate them.

Fixes: 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older versions")

Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
 drivers/net/hyperv/netvsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index c9910c3..d65b7fc 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -590,13 +590,13 @@ void netvsc_device_remove(struct hv_device *device)
 	netdev_dbg(ndev, "net device safe to remove\n");
 
 	/* older versions require that buffer be revoked before close */
-	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_4)
+	if (vmbus_proto_version < VERSION_WIN10)
 		netvsc_teardown_gpadl(device, net_device);
 
 	/* Now, we can close the channel safely */
 	vmbus_close(device->channel);
 
-	if (net_device->nvsp_version >= NVSP_PROTOCOL_VERSION_4)
+	if (vmbus_proto_version >= VERSION_WIN10)
 		netvsc_teardown_gpadl(device, net_device);
 
 	/* Release all resources */
-- 
1.8.3.1

  reply	other threads:[~2018-04-05 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 19:09 [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts Mohammed Gamal
2018-04-05 19:09 ` Mohammed Gamal [this message]
2018-04-10 13:49   ` [PATCH 1/4] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown Sasha Levin
2018-04-05 19:09 ` [PATCH 2/4] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl() Mohammed Gamal
2018-04-10 13:49   ` Sasha Levin
2018-04-05 19:09 ` [PATCH 3/4] hv_netvsc: Ensure correct teardown message sequence order Mohammed Gamal
2018-04-10 13:49   ` Sasha Levin
2018-04-05 19:09 ` [PATCH 4/4] hv_netvsc: Pass net_device parameter to revoke and teardown functions Mohammed Gamal
2018-04-06  2:21 ` [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522955361-14704-2-git-send-email-mgamal@redhat.com \
    --to=mgamal@redhat.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=otubo@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox