From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Elwell Subject: [PATCH] lan78xx: Avoid spurious kevent 4 "error" Date: Wed, 11 Apr 2018 12:02:47 +0100 Message-ID: <1523444567-128200-1-git-send-email-phil@raspberrypi.org> Cc: Phil Elwell To: Woojung Huh , Microchip Linux Driver Support , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:52784 "EHLO mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbeDKLCy (ORCPT ); Wed, 11 Apr 2018 07:02:54 -0400 Received: from pps.filterd (m0102629.ppops.net [127.0.0.1]) by mx08-00252a01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3BB2qDZ009964 for ; Wed, 11 Apr 2018 12:02:53 +0100 Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by mx08-00252a01.pphosted.com with ESMTP id 2h6trdt026-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Wed, 11 Apr 2018 12:02:53 +0100 Received: by mail-wm0-f71.google.com with SMTP id v189so938388wmf.4 for ; Wed, 11 Apr 2018 04:02:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: lan78xx_defer_event generates an error message whenever the work item is already scheduled. lan78xx_open defers three events - EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware of the likelihood (or certainty) of an error message, the DEV_OPEN event is added to the set of pending events directly, relying on the subsequent deferral of the EVENT_LINK_RESET call to schedule the work. Take the same precaution with EVENT_STAT_UPDATE to avoid a totally unnecessary error message. Signed-off-by: Phil Elwell --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 32cf217..3102374 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2507,7 +2507,7 @@ static void lan78xx_init_stats(struct lan78xx_net *dev) dev->stats.rollover_max.eee_tx_lpi_transitions = 0xFFFFFFFF; dev->stats.rollover_max.eee_tx_lpi_time = 0xFFFFFFFF; - lan78xx_defer_kevent(dev, EVENT_STAT_UPDATE); + set_bit(EVENT_STAT_UPDATE, &dev->flags); } static int lan78xx_open(struct net_device *net) -- 2.7.4