From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saeed Mahameed Subject: Re: [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section Date: Wed, 11 Apr 2018 23:47:50 +0000 Message-ID: <1523490467.3587.20.camel@mellanox.com> References: <20180410170812.18905-1-saeedm@mellanox.com> <20180410.131649.583776764903333305.davem@davemloft.net> <75137dbf-4608-127e-1601-10a3c13e3a32@gmail.com> <1523473143.3402.55.camel@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" To: "eric.dumazet@gmail.com" , "davem@davemloft.net" Return-path: Received: from mail-eopbgr40051.outbound.protection.outlook.com ([40.107.4.51]:56352 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752212AbeDKXrz (ORCPT ); Wed, 11 Apr 2018 19:47:55 -0400 In-Reply-To: Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE4LTA0LTExIGF0IDE1OjMwIC0wNzAwLCBFcmljIER1bWF6ZXQgd3JvdGU6DQo+ IA0KPiBPbiAwNC8xMS8yMDE4IDExOjU5IEFNLCBTYWVlZCBNYWhhbWVlZCB3cm90ZToNCj4gPiBP biBUdWUsIDIwMTgtMDQtMTAgYXQgMTM6MzUgLTA3MDAsIEVyaWMgRHVtYXpldCB3cm90ZToNCj4g PiA+IA0KPiA+ID4gT24gMDQvMTAvMjAxOCAxMDoxNiBBTSwgRGF2aWQgTWlsbGVyIHdyb3RlOg0K PiA+ID4gPiANCj4gPiA+ID4gVGhlIHRyYWRlb2ZmIGhlcmUgaXMgdGhhdCBub3cgeW91IGFyZSBk b2luZyB0d28gdW5uZWNlc3NhcnkNCj4gPiA+ID4gYXRvbWljDQo+ID4gPiA+IG9wZXJhdGlvbnMg cGVyIHN0YXRzIGR1bXAuDQo+ID4gPiA+IA0KPiA+ID4gPiBUaGF0IGlzIHdoYXQgdGhlIFJDVSBs b2NrIGFsbG93cyB1cyB0byBhdm9pZC4NCj4gPiA+ID4gDQo+ID4gPiANCj4gPiA+IGRldl9ob2xk KCkgYW5kIGRldl9wdXQoKSBhcmUgYWN0dWFsbHkgcGVyIGNwdSBpbmNyZW1lbnQgYW5kDQo+ID4g PiBkZWNyZW1lbnRzLA0KPiA+ID4gcHJldHR5IGNoZWFwIHRoZXNlIGRheXMuDQo+ID4gPiANCj4g PiANCj4gPiBZZXMsIGkgYW0gYWRkaW5nIG9ubHkgMiBjcHUgaW5zdHJ1Y3Rpb25zIGhlcmUuDQo+ ID4gSSB0aGluayB0aGUgdHJhZGUtb2ZmIGhlcmUgaXMgdG9vIHNtYWxsIGFuZCB0aGUgcHJpY2Ug dG8gZmluYWxseQ0KPiA+IGhhdmUNCj4gPiBnZXRfc3RhdHM2NCBjYWxsZWQgZnJvbSBub24gYXRv bWljIGNvbnRleHQgaXMgcmVhbGx5IHdvcnRoIGl0Lg0KPiANCj4gT2guLi4gYnV0IHlvdSBoYXZl IG5vdCBtZW50aW9uZWQgdGhpcyByZWFzb24gaW4geW91ciBjaGFuZ2Vsb2cuDQo+IA0KDQpmcm9t IHRoZSBjb21taXQgbWVzc2FnZToNCg0KIlRoaXMgaXMgcmVhbGx5IGdyZWVkeSBhbmQgZGVtYW5k aW5nIGZyb20gZGV2aWNlIGRyaXZlcnMgc2luY2UNCm5kb19nZXRfc3RhdHM2NCBjYWxsZWQgZnJv bSBkZXZfc2VxX3Nob3cgd2hpbGUgdGhlIHJjdSBsb2NrIGlzIGhlbGQiDQoNCnNvcnJ5IGlmIHRo aXMgd2Fzbid0IGNsZWFyIGVub3VnaCBJIHdpbGwgZml4IHRoaXMgaWYgdGhpcyBnb2VzIHRocm91 Z2guDQoNCj4gV2hhdCBhYm91dCBib25kaW5nIHN0YXRzID8NCj4gDQo+IEJ5IHNlbmRpbmcgcGFy dGlhbCBwYXRjaGVzIGxpa2UgdGhhdCwgb3RoZXJzIGhhdmUgdG8gdGFrZSBjYXJlIG9mIHRoZQ0K PiBkZXRhaWxzDQo+IGFuZCB0aGlzIGlzIG5vdCByZWFsbHkgYWNjZXB0YWJsZS4NCj4gDQoNClRo aXMgaXMgYSBSRkMganVzdCB0byBzaG93IHRoZSBhcHByb2FjaCwgaWYgdGhlIGFwcHJvYWNoIGlz IGFjY2VwdGFibGUNCm9mIGNvdXJzZSBpIHdpbGwgcHJvdmlkZSBhIGZ1bGwgc2VyaWVzIHRoYXQg d2lsbCBoYW5kbGUgYWxsIG90aGVyDQpwbGFjZXMsIHRoZSBjaGFuZ2Ugc2hvdWxkIGJlIHRoZSBz YW1lLCBJIGFscmVhZHkgaGF2ZSAyIG90aGVyIHBhdGNoZXMNCnRvIGFkZHJlc3Mgb3ZzIGFuZCBu ZXRsaW5rIHN0YXRzLCBpIGp1c3QgZGlkbid0IHdhbnQgdG8gd2FzdGUgeW91ciB0aW1lDQpvbiBz bWFsbCBkZXRhaWxzIGxpa2UgbmV0bGluayBtZXNzYWdlcy4NCg0KPiA+IA0KPiA+IEl0ICBsb29r cyByZWFsbHkgb2RkIHRvIG1lIHRoYXQgdGhlIGRldmljZSBjaGFpbiBsb2NrcyBhcmUgaGVsZCBm b3INCj4gPiBzdWNoIGxvbmcgcGVyaW9kcywgd2hpbGUgd2UgYWxyZWFkeSBoYXZlIHRoZSBtZWFu cyB0byBhdm9pZCB0aGlzLA0KPiA+IHNhbWUNCj4gPiBnb2VzIGZvciBydG5sX2xvY2ssIHNhbWUg dHJpY2sgY2FuIHdvcmsgaGVyZSBmb3IgbWFueSB1c2UgY2FzZXMgYW5kDQo+ID4gbWFueSBuZG9z LCB3ZSBhcmUganVzdCBvdmVyIHByb3RlY3RpdmUgZm9yIG5vIHJlYXNvbnMuDQo+ID4gDQo+ID4g DQo+ID4gPiBQcm9ibGVtIGhlcmUgaXMgdGhhdCBhbnkgcHJlZW1wdGlvbiBvZiB0aGUgcHJvY2Vz cyBob2xkaW5nIGRldmljZQ0KPiA+ID4gcmVmZXJlbmNlDQo+ID4gPiBtaWdodCB0cmlnZ2VyIHdh cm5pbmdzIGluIGRldmljZSB1bnJlZ2lzdGVyLg0KPiA+ID4gDQo+ID4gDQo+ID4gVGhpcyBpcyB0 cnVlIGZvciBhbnkgb3RoZXIgcGxhY2UgZGV2X2hvbGQgaXMgdXNlZCwNCj4gPiBhcyBleHBsYWlu ZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIGRldl9ob2xkIGlzIHVzZWQgZm9yIGEgdmVyeQ0KPiA+ IGJyaWVmDQo+ID4gbW9tZW50IGJlZm9yZSBjYWxsaW5nIHRoZSBzdGF0cyBuZG8gYW5kIHJlbGVh c2VkIGRpcmVjdGx5IGFmdGVyLg0KPiANCj4gTm90IHJlYWxseS4NCj4gDQo+IE90aGVyIHBsYWNl cyB1c3VhbGx5IGhhdmUgbm90aWZpZXJzIHRvIHJlbW92ZSB0aGUgcmVmY291bnQgd2hlbg0KPiBu ZWVkZWQuDQo+IA0KDQpPdGhlciBwbGFjZXMgaG9sZCB0aGUgbmV0ZGV2IGZvciB0aGUgd2hvbGUg bGlmZXRpbWUgb2YgdGhlIG5ldGRldiwgdGhleQ0KZG9uJ3Qga25vdyB3aGVuIHRvIHJlbGVhc2Ug aXQsIHRoaXMgaXMgd2h5IHdlIG5lZWQgbm90aWZpZXJzLg0KDQppbiB0aGlzIHBhdGNoIHRoZSBh cHByb2FjaCBpczoNCg0KaG9sZA0KY2FsbCBuZG8NCnB1dA0KDQpub3RpZmllciBpcyBub3QgbmVl ZGVkIGluIHRoaXMgY2FzZS4NCg0KPiBXZSB3b3JrZWQgcXVpdGUgaGFyZCBpbiB0aGUgcGFzdCB0 byByZW1vdmUgZXh0cmEgZGV2X2hvbGQoKQ0KPiAoYmVmb3JlIHdlIGZpbmFsbHkgY29udmVydGVk IGl0IHRvIHBlcmNwdSBjb3VudGVyKQ0KPiANCj4gPiANCj4gPiBsb29raW5nIGF0IA0KPiA+IA0K PiA+IG5ldGRldl93YWl0X2FsbHJlZnMoLi4uKQ0KPiA+IFsuLi5dDQo+ID4gCW1zbGVlcCgyNTAp Ow0KPiA+IA0KPiA+IAlyZWZjbnQgPSBuZXRkZXZfcmVmY250X3JlYWQoZGV2KTsNCj4gPiANCj4g PiAJaWYgKHRpbWVfYWZ0ZXIoamlmZmllcywgd2FybmluZ190aW1lICsgMTAgKiBIWikpIHsNCj4g PiAJCXByX2VtZXJnKCJ1bnJlZ2lzdGVyX25ldGRldmljZTogd2FpdGluZyBmb3IgJXMgdG8NCj4g PiBiZWNvbWUgZnJlZS4gVXNhZ2UgY291bnQgPSAlZFxuIiwNCj4gPiAJCQkgZGV2LT5uYW1lLCBy ZWZjbnQpOw0KPiA+IAkJd2FybmluZ190aW1lID0gamlmZmllczsNCj4gPiAJfQ0KPiA+IA0KPiA+ IFRoZSBob2xkZXIgd2lsbCBnZXQgZW5vdWdoIHRpbWUgdG8gcmVsZWFzZSB0aGUgbmV0ZGV2IHdh eSBiZWZvcmUNCj4gPiB0aGUNCj4gPiB3YXJuaW5nIGlzIHRyaWdnZXJlZC4NCj4gPiANCj4gPiBU aGUgd2FybmluZyBpcyB0cmlnZ2VyZWQgb25seSBpZiBzb21lb25lIGhvbGRzIHRoZSBkZXYgZm9y IG1vcmUNCj4gPiB0aGFuIDEwDQo+ID4gc2Vjb25kcyB3aGljaCBpcyBpbXBvc3NpYmxlIGZvciB0 aGUgc3RhdHMgbmRvIHRvIHRha2UgbW9yZSB0aGFuDQo+ID4gdGhpcywNCj4gPiBpbiBmYWN0IGkg anVzdCBkaWQgYSBxdWljayBtZWFzdXJlbWVudCBhbmQgaXQgc2VlbXMgdGhhdCBpbiBhdmVyYWdl DQo+ID4gZ2V0X3N0YXRzNjQgbmRvIHRha2VzIDAuNXVzICENCj4gDQo+IEF2ZXJhZ2UgaXMgbmlj ZSwgYnV0IHdoYXQgYWJvdXQgbWF4IHRpbWUgPw0KPiANCg0KV2VsbCBpZiB3ZSBhbGxvdyBkZXZp Y2VzIHRvIGFjY2VzcyBIVyBjb3VudGVycyB2aWEgRlcgY29tbWFuZA0KaW50ZXJmYWNlcyBpbiBu ZG9fZ2V0X3N0YXRzIGFuZCBieSB0ZXN0aW5nIG1seDUgd2hlcmUgd2UgcXVlcnkgdXAgdG8gNQ0K aHcgcmVnaXN0ZXJzLCBpdCBjb3VsZCB0YWtlIDEwMHVzLCBzdGlsbCB0aGlzIGlzIHdheSBzbWFs bGVyIHRoYW4gMTBzZWMNCiA6KSBhbmQgaXQgaXMgcmVhbGx5IGEgbmljZSByYXRlIHRvIGZldGNo IEhXIHN0YXRzIG9uIGRlbWFuZC4NCg0KPiBTbGVlcGluZyBtb3JlIHRoYW4gMTAgc2Vjb25kcyB0 byBzYXRpZnkgR0ZQX0tFUk5FTCBtZW1vcnkgYWxsb2NhdGlvbg0KPiBjYW4gZGVmaW5pdGVseQ0K PiBoYXBwZW4gaW4gdGhlIHJlYWwgd29ybGQsIG9yIHNpbXBseSBpZiB5b3UgZ2V0IHByZWVtcHRl ZCBieSBzb21lDQo+IFJUL2hpZ2ggcHJpbyB0YXNrcy4NCj4gDQoNClNhbWUgaXNzdWUgY2FuIG9j Y3VyIHdpdGhvdXQgdGhpcyBwYXRjaCBpZiBhbiBJUlEgaXMgdHJpZ2dlcmVkIHVuZGVyDQp3aGls ZSB1bmRlciByY3UgbG9jay4NCkFuZCBSVC9oaWdoIHByaW8gdGFzayBzaG91bGRuJ3QgdGFrZSBt b3JlIHRoYW4gMTBzZWMuDQoNCkluIGNhc2UgR0ZQX0tFUk5FTCBtZW1vcnkgYWxsb2NhdGlvbiB0 YWtlcyBtb3JlIHRoYW4gMTBzZWMgeW91IHdpbGwNCmFscmVhZHkgZ2V0IHRvbnMgb2YgT09NIHdh cm5pbmdzLg0KSGF2aW5nIGEgbmV0ZGV2IHdhcm5pbmcgaW4gY2FzZSBvZiByZWFsbHkgdGhlIG5l dGRldiBpcyBiZWluZw0KdW5yZWdpc3RlcmVkIGFuZCBuZG9fZ2V0X3N0YXRzIHdhcyBwcmVlbXB0 ZWQgZm9yIG1vcmUgdGhhbiAxMCBzZWNvbmRzDQp3aWxsIGJlIHRoZSBsZWFzdCBvZiB5b3VyIHBy b2JsZW1zLg0KDQo+IEp1c3Qgc2F5IG5vIHRvICdtaWdodCBzbGVlcCBpbiBuZG9fZ2V0X3N0YXRz KCknLCBhbmQgeW91IHdpbGwgc2F2ZSBhDQo+IGxvdCBvZiBpc3N1ZXMuDQoNCldlIGFyZSBqdXN0 IGJlaW5nIG92ZXIgcHJvdGVjdGl2ZSBoZXJlLg0KDQpKdXN0IHNheSBubyB0byAnbWlnaHQgc2xl ZXAgaW4gbmRvX2dldF9zdGF0cygpJyBpcyBieSBpdHNlbGYgY3JlYXRpbmcgYQ0KbG90IG9mIGlz c3VlcywgbWFueSBkcml2ZXJzIG91dCB0aGVyZSBoYXZlIGEgYmFja2dyb3VuZCB0aHJlYWQgcnVu bmluZw0KTiB0aW1lcyBhIHNlY29uZCBqdXN0IHRvIGNhY2hlIEhXIHN0YXRzLiB3aGljaCBpcyBy ZWFsbHkgc2lsbHkgYW5kIENQVQ0KY29uc3VtaW5nIGZvciBubyByZWFzb24uDQoNClRoZSByYXRl IG9mIG5kb19nZXRfc3RhdHMgc2hvdWxkIGJlIGVxdWFsIHRvIHRoZSByYXRlIHRoZSBkcml2ZXIg Y2FuDQphY3R1YWxseSBwcm92aWRlIGZyZXNoIHN0YXRzLCBhbnkgYmFja2dyb3VuZCB0aHJlYWQg aXMganVzdCBhIGEgd2FzdGUNCm9mIENQVS4gQ291bnRlcnMgc2hvdWxkIGJlIGZldGNoZWQgZnJv bSBIVyBvbiBkZW1hbmQgcmF0aGVyIHRoYW4NCnBlcmlvZGljYWxseSBmb3Igbm8gcmVhc29uLg0K DQpUaGUgc2FtZSBnb2VzIGZvciBzZXRfcnhfbW9kZSBuZG8uDQoNCkJvdHRvbSBsaW5lIGl0IGxv b2tzIGxpa2UgdGhlIG5lZWQgZm9yIHJjdSBsb2NraW5nIHRvZGF5IGlzIG9ubHkgbWVhbnQNCmZv ciBzeW5jaHJvbml6aW5nIGFjY2Vzc2luZyB0aGUgbmV0ZGV2IG5kbyB3aXRoIHRoZSBkZXZpY2Ug Y2hhaW4gaW4NCnF1ZXN0aW9uIChuYW1lc3BhY2Uvb3ZzL2JvbmRpbmcvZXRjIC4uICkuDQoNClRo ZXJlIGFyZSBtYW55IHBsYWNlcyB3aGVyZSBkZXZfZ2V0X3N0YXRzIGlzIGNhbGxlZCBmcm9tIG5v biBhdG1vaWMNCmNvbnRleHQgd2hlcmUgdGhlIGNhbGxlciBrbm93cyBpdCBpcyBzYWZlIHRvIGFj Y2VzcyB0aGUgbmV0ZGV2IG5kby4NCg0KZXhhbXBsZToNCm5ldC9ib25kaWduL2JvbmRfbWFpbi5j OiBib25kX2Vuc2xhdmUoLi4pDQoNCi8qIGluaXRpYWxpemUgc2xhdmUgc3RhdHMgKi8NCmRldl9n ZXRfc3RhdHMobmV3X3NsYXZlLT5kZXYsICZuZXdfc2xhdmUtPnNsYXZlX3N0YXRzKTsNCg0K