From: jassisinghbrar@gmail.com
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, masahisa.kojima@linaro.org,
ard.biesheuvel@linaro.org,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: [PATCH 1/2] net: netsec: enable tx-irq during open callback
Date: Mon, 16 Apr 2018 12:52:16 +0530 [thread overview]
Message-ID: <1523863336-12653-1-git-send-email-jassisinghbrar@gmail.com> (raw)
From: Jassi Brar <jaswinder.singh@linaro.org>
Enable TX-irq as well during ndo_open() as we can not count upon
RX to arrive early enough to trigger the napi. This patch is critical
for installation over network.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
drivers/net/ethernet/socionext/netsec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index f4c0b02..f6fe70e 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
napi_enable(&priv->napi);
netif_start_queue(ndev);
- /* Enable RX intr. */
- netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
+ /* Enable TX+RX intr. */
+ netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
return 0;
err3:
--
2.7.4
next reply other threads:[~2018-04-16 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 7:22 jassisinghbrar [this message]
2018-04-16 17:46 ` [PATCH 1/2] net: netsec: enable tx-irq during open callback David Miller
2018-04-18 12:57 ` Jassi Brar
2018-04-18 17:30 ` David Miller
2018-07-19 5:37 ` Jassi Brar
2018-08-23 5:15 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523863336-12653-1-git-send-email-jassisinghbrar@gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=jaswinder.singh@linaro.org \
--cc=masahisa.kojima@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).