* [PATCH 1/2] net: netsec: enable tx-irq during open callback
@ 2018-04-16 7:22 jassisinghbrar
2018-04-16 17:46 ` David Miller
2018-08-23 5:15 ` Jassi Brar
0 siblings, 2 replies; 6+ messages in thread
From: jassisinghbrar @ 2018-04-16 7:22 UTC (permalink / raw)
To: netdev; +Cc: davem, masahisa.kojima, ard.biesheuvel, Jassi Brar
From: Jassi Brar <jaswinder.singh@linaro.org>
Enable TX-irq as well during ndo_open() as we can not count upon
RX to arrive early enough to trigger the napi. This patch is critical
for installation over network.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
drivers/net/ethernet/socionext/netsec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index f4c0b02..f6fe70e 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
napi_enable(&priv->napi);
netif_start_queue(ndev);
- /* Enable RX intr. */
- netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
+ /* Enable TX+RX intr. */
+ netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
return 0;
err3:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback
2018-04-16 7:22 [PATCH 1/2] net: netsec: enable tx-irq during open callback jassisinghbrar
@ 2018-04-16 17:46 ` David Miller
2018-04-18 12:57 ` Jassi Brar
2018-08-23 5:15 ` Jassi Brar
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2018-04-16 17:46 UTC (permalink / raw)
To: jassisinghbrar; +Cc: netdev, masahisa.kojima, ard.biesheuvel, jaswinder.singh
From: jassisinghbrar@gmail.com
Date: Mon, 16 Apr 2018 12:52:16 +0530
> From: Jassi Brar <jaswinder.singh@linaro.org>
>
> Enable TX-irq as well during ndo_open() as we can not count upon
> RX to arrive early enough to trigger the napi. This patch is critical
> for installation over network.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback
2018-04-16 17:46 ` David Miller
@ 2018-04-18 12:57 ` Jassi Brar
2018-04-18 17:30 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Jassi Brar @ 2018-04-18 12:57 UTC (permalink / raw)
To: David Miller
Cc: <netdev@vger.kernel.org>, Masahisa Kojima, Ard Biesheuvel,
Jassi Brar
Hi Dave,
On Mon, Apr 16, 2018 at 11:16 PM, David Miller <davem@davemloft.net> wrote:
> From: jassisinghbrar@gmail.com
> Date: Mon, 16 Apr 2018 12:52:16 +0530
>
>> From: Jassi Brar <jaswinder.singh@linaro.org>
>>
>> Enable TX-irq as well during ndo_open() as we can not count upon
>> RX to arrive early enough to trigger the napi. This patch is critical
>> for installation over network.
>>
>> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
>> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
>
> Applied.
>
Just to make sure, let me please mention that c009f413b79de52 and
9a00b697ce31e are very much needed in stable kernel. Without these we
couldn't install any OS over network.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback
2018-04-18 12:57 ` Jassi Brar
@ 2018-04-18 17:30 ` David Miller
2018-07-19 5:37 ` Jassi Brar
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2018-04-18 17:30 UTC (permalink / raw)
To: jassisinghbrar; +Cc: netdev, masahisa.kojima, ard.biesheuvel, jaswinder.singh
From: Jassi Brar <jassisinghbrar@gmail.com>
Date: Wed, 18 Apr 2018 18:27:59 +0530
> Just to make sure, let me please mention that c009f413b79de52 and
> 9a00b697ce31e are very much needed in stable kernel. Without these we
> couldn't install any OS over network.
Ok, both patches in this series queued up for -stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback
2018-04-18 17:30 ` David Miller
@ 2018-07-19 5:37 ` Jassi Brar
0 siblings, 0 replies; 6+ messages in thread
From: Jassi Brar @ 2018-07-19 5:37 UTC (permalink / raw)
To: David Miller
Cc: <netdev@vger.kernel.org>, Masahisa Kojima, Ard Biesheuvel,
Jassi Brar
Hi David,
On Wed, Apr 18, 2018 at 11:00 PM, David Miller <davem@davemloft.net> wrote:
> From: Jassi Brar <jassisinghbrar@gmail.com>
> Date: Wed, 18 Apr 2018 18:27:59 +0530
>
>> Just to make sure, let me please mention that c009f413b79de52 and
>> 9a00b697ce31e are very much needed in stable kernel. Without these we
>> couldn't install any OS over network.
>
> Ok, both patches in this series queued up for -stable.
>
I don't see the patches still. Could you please have a relook.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback
2018-04-16 7:22 [PATCH 1/2] net: netsec: enable tx-irq during open callback jassisinghbrar
2018-04-16 17:46 ` David Miller
@ 2018-08-23 5:15 ` Jassi Brar
1 sibling, 0 replies; 6+ messages in thread
From: Jassi Brar @ 2018-08-23 5:15 UTC (permalink / raw)
To: <netdev@vger.kernel.org>
Cc: David S . Miller, Masahisa Kojima, Ard Biesheuvel, Jassi Brar
Hi Dave,
This patch (1/2) seems to have fallen through the cracks. The other
one (2/2), you already picked.
Thanks
On Mon, Apr 16, 2018 at 1:08 PM <jassisinghbrar@gmail.com> wrote:
>
> From: Jassi Brar <jaswinder.singh@linaro.org>
>
> Enable TX-irq as well during ndo_open() as we can not count upon
> RX to arrive early enough to trigger the napi. This patch is critical
> for installation over network.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> ---
> drivers/net/ethernet/socionext/netsec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index f4c0b02..f6fe70e 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
> napi_enable(&priv->napi);
> netif_start_queue(ndev);
>
> - /* Enable RX intr. */
> - netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
> + /* Enable TX+RX intr. */
> + netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
>
> return 0;
> err3:
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-23 8:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-16 7:22 [PATCH 1/2] net: netsec: enable tx-irq during open callback jassisinghbrar
2018-04-16 17:46 ` David Miller
2018-04-18 12:57 ` Jassi Brar
2018-04-18 17:30 ` David Miller
2018-07-19 5:37 ` Jassi Brar
2018-08-23 5:15 ` Jassi Brar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).