From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.
Date: Wed, 18 Apr 2018 23:26:57 +0200 [thread overview]
Message-ID: <1524086817.3024.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1524016176-3881-1-git-send-email-greearb@candelatech.com> (sfid-20180418_034951_095176_E2F46A6C)
On Tue, 2018-04-17 at 18:49 -0700, greearb@candelatech.com wrote:
>
> + * @get_ethtool_stats2: Return extended statistics about the device.
> + * This is only useful if the device maintains statistics not
> + * included in &struct rtnl_link_stats64.
> + * Takes a flags argument: 0 means all (same as get_ethtool_stats),
> + * 0x1 (ETHTOOL_GS2_SKIP_FW) means skip firmware stats.
> + * Other flags are reserved for now.
It'd be pretty hard to know which flags are firmware stats?
Anyway, there's no way I'm going to take this patch, so you need to
float it on netdev first (best CC us here) and get it applied there
before we can do anything on the wifi side.
johannes
next prev parent reply other threads:[~2018-04-18 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 1:49 [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command greearb-my8/4N5VtI7c+919tysfdA
2018-04-18 1:49 ` [PATCH 2/3] mac80211: Add support for ethtool gstats2 API greearb
2018-04-18 1:49 ` [PATCH 3/3] ath10k: Support " greearb
2018-04-19 11:19 ` kbuild test robot
2018-04-18 21:07 ` [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command Florian Fainelli
2018-04-18 21:26 ` Johannes Berg [this message]
2018-04-18 21:51 ` Ben Greear
2018-04-19 6:38 ` Johannes Berg
2018-04-19 15:25 ` Ben Greear
[not found] ` <173c5f98-36bc-2e52-1e64-3a5f89008d46-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2018-04-19 15:26 ` Johannes Berg
[not found] ` <1524151617.3024.25.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-04-22 18:54 ` David Miller
[not found] ` <20180422.145420.1197041027922699603.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2018-04-22 21:15 ` Roopa Prabhu
2018-04-23 15:41 ` Ben Greear
2018-04-23 15:38 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524086817.3024.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).