From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kodanev Subject: [PATCH net-next 3/4] geneve: check MTU for a minimum in geneve_change_mtu() Date: Thu, 19 Apr 2018 15:42:31 +0300 Message-ID: <1524141752-25789-4-git-send-email-alexey.kodanev@oracle.com> References: <1524141752-25789-1-git-send-email-alexey.kodanev@oracle.com> Cc: David Miller , Alexey Kodanev To: netdev@vger.kernel.org Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:58472 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbeDSMdC (ORCPT ); Thu, 19 Apr 2018 08:33:02 -0400 In-Reply-To: <1524141752-25789-1-git-send-email-alexey.kodanev@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: geneve_change_mtu() will be used not only as ndo_change_mtu() callback, but also to verify a user specified MTU on a new link creation in the next patch. Signed-off-by: Alexey Kodanev --- drivers/net/geneve.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index b650f84..ae649f6 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -942,11 +942,10 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, struct net_device *dev) static int geneve_change_mtu(struct net_device *dev, int new_mtu) { - /* Only possible if called internally, ndo_change_mtu path's new_mtu - * is guaranteed to be between dev->min_mtu and dev->max_mtu. - */ if (new_mtu > dev->max_mtu) new_mtu = dev->max_mtu; + else if (new_mtu < dev->min_mtu) + new_mtu = dev->min_mtu; dev->mtu = new_mtu; return 0; -- 1.8.3.1