From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Chan Subject: [PATCH net-next 04/14] bnxt_en: Do not set firmware time from VF driver on older firmware. Date: Wed, 25 Apr 2018 20:40:47 -0400 Message-ID: <1524703257-12812-5-git-send-email-michael.chan@broadcom.com> References: <1524703257-12812-1-git-send-email-michael.chan@broadcom.com> Cc: netdev@vger.kernel.org To: davem@davemloft.net Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:43812 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbeDZAlM (ORCPT ); Wed, 25 Apr 2018 20:41:12 -0400 Received: by mail-pg0-f67.google.com with SMTP id f132so14539395pgc.10 for ; Wed, 25 Apr 2018 17:41:11 -0700 (PDT) In-Reply-To: <1524703257-12812-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: Older firmware will reject this call and cause an error message to be printed by the VF driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index bda618d..aff4b4e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5379,7 +5379,8 @@ int bnxt_hwrm_fw_set_time(struct bnxt *bp) struct tm tm; time64_t now = ktime_get_real_seconds(); - if (bp->hwrm_spec_code < 0x10400) + if ((BNXT_VF(bp) && bp->hwrm_spec_code < 0x10901) || + bp->hwrm_spec_code < 0x10400) return -EOPNOTSUPP; time64_to_tm(now, 0, &tm); -- 1.8.3.1