From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next 2/4] bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only.
Date: Tue, 8 May 2018 03:18:39 -0400 [thread overview]
Message-ID: <1525763921-20698-3-git-send-email-michael.chan@broadcom.com> (raw)
In-Reply-To: <1525763921-20698-1-git-send-email-michael.chan@broadcom.com>
Only non-NPAR PFs need to actively check and manage unsupported link
speeds. NPAR functions and VFs do not control the link speed and
should skip the unsupported speed detection logic, to avoid warning
messages from firmware rejecting the unsupported firmware calls.
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 168342a..cd3ab78 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6462,6 +6462,9 @@ static int bnxt_update_link(struct bnxt *bp, bool chng_link_state)
}
mutex_unlock(&bp->hwrm_cmd_lock);
+ if (!BNXT_SINGLE_PF(bp))
+ return 0;
+
diff = link_info->support_auto_speeds ^ link_info->advertising;
if ((link_info->support_auto_speeds | diff) !=
link_info->support_auto_speeds) {
--
1.8.3.1
next prev parent reply other threads:[~2018-05-08 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 7:18 [PATCH net-next 0/4] bnxt_en: Fixes for net-next Michael Chan
2018-05-08 7:18 ` [PATCH net-next 1/4] bnxt_en: Fix firmware message delay loop regression Michael Chan
2018-05-08 7:18 ` Michael Chan [this message]
2018-05-08 7:18 ` [PATCH net-next 3/4] bnxt_en: Read phy eeprom A2h address only when optical diagnostics is supported Michael Chan
2018-05-08 7:18 ` [PATCH net-next 4/4] bnxt_en: Always forward VF MAC address to the PF Michael Chan
2018-09-14 12:49 ` Siwei Liu
2018-05-08 14:15 ` [PATCH net-next 0/4] bnxt_en: Fixes for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525763921-20698-3-git-send-email-michael.chan@broadcom.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).